empty list item in ul class product-description [#726246]

function theme_uc_product_attributes, in uc_attribute.admin.inc, outputs a list to the order record + customer email, with one list item for my one option, plus an empty list item. For a product that has no options, it outputs an empty list item. It prints the bullet followed by the colon that would come between the attribute name and the option.

Posting as a support request rather than a bug report since I can't find anyone else reporting this. Any help why I would be seeing this?

Comments

Comment #1

TR CreditAttribution: TR commented 27 February 2010 at 18:45

Issue tags:

+Ubercart theme layer

Tagging

Comment #2

TR CreditAttribution: TR commented 28 February 2010 at 21:29

Status:

Active

» Postponed (maintainer needs more info)

Where (i.e. what page) are you seeing this empty list item?

When you say "For a product that has no options" do you really mean "For a product that has no attributes" Or does your product have a textfield attribute with no options? If the latter, is the textfield a required attribute or not?

Please give me step-by-step directions for reproducing this, including a description of how you set up your product (exactly what attributes/attribute types/options) and what page you're looking at that looks wrong.

Comment #3

echoz CreditAttribution: echoz commented 1 March 2010 at 23:44

Thanks. As I wrote, this is in the output of the individual order record seen from admin/store/orders/view, and the customer email, which is also viewable from the Invoice tab of that same page. It appears correctly with no extra empty bullet on cart, cart/checkout, cart/checkout/review or the cart block.

Yes I meant "for a product that has no attributes".

I have a product class that has one attribute, with options as radio buttons. This is set up as the default attribute for the class (created from admin/store/attributes/add, then added to the product class from admin/store/products/classes/MYCLASS/attributes/add).

Comment #4

echoz CreditAttribution: echoz commented 2 March 2010 at 02:21

I just realized I also applied this override to function theme_uc_node_checkout_node_attributes in uc_node_checkout
from this post: http://drupal.org/node/548848#comment-2004278

Where I will now post this.

Comment #5

TR CreditAttribution: TR commented 3 March 2010 at 18:22

OK, there is no page admin/store/orders/view. Do you mean admin/store/order/#, where # is an order number?

Anyway, I can't reproduce this problem. Looking at the issue you cited in #4 I see you're hunch is right - it's that patch which is causing a problem. It is improperly looking over the options on an attribute.