Am I wrong, or does the module includes (and commits in CVS) files licensed under GPL License V3, where they should be licensed under the same license used by Drupal?

Members fund testing for the Drupal project. Drupal Association Learn more


jbrown’s picture

Category: support » bug
Status: Active » Needs work

Yes - it should use Libraries API.

See also #579950: Commercial version SWF.

RobLoach’s picture

Title: Module includes files licensed under GPL License v3 » Move to Libraries API to remove Flowplayer binaries and GPL 3 code
Category: bug » task
Priority: Normal » Critical

I'd love for this move to happen! We'll have to really document the installation of the plugins (like RTMP) as they're downloaded seperately from the main Flowplayer package.

lpalgarvio’s picture

Status: Needs work » Active

well, start by moving the files out of the archive and reading from sites/all/libraries/flowplayer3.

that's a good start.

lpalgarvio’s picture

and btw, the flowplayer bundles are outdated too...

osopolar’s picture

I created a patch for this, which allows to set the library path to flowplayer manually or with the use of the libraries module. I added a README.txt and removed the flowplayer files.

I will leave the priority to critical because we need to remove the flowplayer plugin from the module!
SEE: Question 4, 5 and 10.

To outsource the flowplayer will also enable it to update. But be careful, the last version provided by this module was 3.1.5. There could be some compatibility issues with newer versions. This is *not* part of this issue. If there are compatibility issues, please open a new issue.

osopolar’s picture

Status: Active » Needs review
36.02 KB
jrreid’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
40.25 KB

Here is a reroll of the patch against 7.x-1.x. I added a few more helper functions to get the path to the .swf and .js files individually, since the flowplayer package itself keeps the version number in the file names so we can't just specify them directly.

osopolar’s picture

@jrreid: Not sure, but maybe just look once for the libraries and store them with variable_set(). And refresh this variable only when showing the settings page + list the files on the settings page.

arisaves’s picture

Hey, jrreid -- I've managed to apply the patch -- but I'm having a tough time configuring the library path. I've added the files to my /sites/all/libraries directory and added the path to the module configuration, but no dice. I am desperately trying to add my own branding, but to no avail. I've tried via array in the video module, in the flowplayer module, and using the JS api.

andy.s.clark’s picture

Recreated patch with --binary option. Without --binary option, running git apply complains about the binary files.

The patch expects the Flowplayer SWF to have the format 'flowplayer-*.swf'. It also expects flowplayer-3.2.10.min.js to be in the examples sub-folder. After extracting Flowplayer Commercial into sites/all/libraries/flowplayer...

  • Rename 'flowplayer.commercial-3.2.11.swf' to 'flowplayer-commercial-3.2.11.swf'
  • Move 'flowplayer-3.2.10.min.js' to 'example/flowplayer-3.2.10.min.js'
arisaves’s picture

Andy, I am having a bit of difficulty applying the patch -- is there a different procedure for applying binary patches?

andy.s.clark’s picture

Applying the patch appears to work fine by just doing "git apply flowplayer-libraries-722604-10.patch".

joelwallis’s picture

Subscribing to this issue. What have been decided since then? Flowplayer is going to be in Libraries' folder?

DamienMcKenna’s picture

DamienMcKenna’s picture

41.16 KB

WIP, will also add support for v5 of the player. This patch also completely removes the existing Flowplayer files and adds a note to the README file about it.

kreynen’s picture

The Drupal Association recently approved a Licensing Working Group with the authority to finally deal with issues like this. #722554: flowplayer module includes Flash player protected with GPL 3 licence is the duplicate issue in the LWG queue.

Once the process is established for dealing with violations, if the maintainers of the project do not resolve the issue the project will likely be treated more like an unresolved security issue. The project's releases will be unpublished and a notice will be posted to the project page.

More importantly, the maintainers who violated the risk losing their git privileges.

If this project is abandoned, it would be great to find a new maintainer willing to make this change to avoid having to unpublish a project used by > 7,400 sites.

  • RobLoach committed d41e4e3 on 7.x-2.x
    Issue #722604 by osopolar, DamienMcKenna, andy.s.clark, jrreid: Move to...
RobLoach’s picture

Thanks for the note, @kreynen. Did a couple things:

  1. Opened up the 7.x-2.x branch
  2. Committed the patch in this thread
  3. Put up a dev release for 2.x
  4. Added osopolar, DamienMcKenna , andy.s.clark and jrreid as maintainers of the module
  5. Made the new 2.x release the recommended release

If there's anything missing, let's file new issues against 2.x. Feel free to review this one and set to fixed if it seems sufficient to you.

kreynen’s picture

Status: Needs review » Fixed
Kebz’s picture

On the configuration link here "admin/config/media/flowplayer"

It asks for this "Flowplayer Library Path"

Where can I find the files so that I can upload to my "libraries" (path = /sites/all/libraries) section?

Kebz’s picture

Status: Fixed » Needs review
kreynen’s picture

Status: Needs review » Fixed

While related to this change, this is really a support request. You can find links to the downloads and the source at

If that doesn't resolve your problem, please open a new support request.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.