Third parameter of user_module_invoke() should be object but user_register_validate() calls it with an array instead.

Same problem here.

Patch solves the problem for me.

The bug has apparently been around as long as function itself: Mon, 21 Nov 2005.

Slighly smaller/simpler patch; needs testing.

Tagging. Note that D7 likewise casts $form_state['values'] to an object, in the entity_form_field_validate function.

The user_register_validate function was created Mon, 21 Nov 2005, removed Sat, 10 Oct 2009, and recreated Tue, 30 Nov 2010.

So this patch is technically a backport of the fix incidental to:

• #118345: Revamp hook_user_form/_register/_validate/_submit/_insert/_update
• #501408: Display user fields on registration form

Affects CiviCRM -- that's how I found/fixed it in the first place.

Better title?

I can't believe I'm bikeshedding this...

Patch in #1 was the correct approach. Re-uploading for the sake of clarity.

Looks good. Who else tested this?

Dunno, but at least one other person (the original reporter) was affected by the problem, and the suggested fix seems self-evident to me. The only other fix I could imagine is to move the cast to user_module_invoke():

diff --git modules/user/user.module modules/user/user.module
index 7f22f7c..43f96e6 100644
--- modules/user/user.module
+++ modules/user/user.module
@@ -80,6 +80,7 @@ function user_help($path, $arg) {
  * be passed by reference.
  */
 function user_module_invoke($type, &$edit, $account, $category = NULL) {
+  $account = (object) $account;
   foreach (module_implements('user_' . $type) as $module) {
     $function = $module . '_user_' . $type;
     $function($edit, $account, $category);

diff --git modules/user/user.module modules/user/user.module
index 2e12c17..39624e9 100644
--- modules/user/user.module
+++ modules/user/user.module
@@ -16,6 +16,7 @@ define('EMAIL_MAX_LENGTH', 64);
  * be passed by reference.
  */
 function user_module_invoke($type, &$array, &$user, $category = NULL) {
+  $user = (object) $user;
   foreach (module_list() as $module) {
     $function = $module .'_user';
     if (function_exists($function)) {

Again, it seems self-evident that the patch in #1/#8 is preferable, especially since the D7 patch above is unnecessary and arguably wrong.

Trying again...

Okay, so the testbot doesn't like it when I follow instructions on how to submit patches.

Trying again with "git diff -no-prefix"

Go, testbot!

oh, tay.
so maybe testbot is trying (once again) to apply D6 patches to D8 core?

Does not seem like anybody tested this in the community beyond the patch creator?!

I guess nobody cares about fixing long-standing bugs in the d6 api. I get quicker results with d8 bugs, in fact.

Added link on user_register_validate() api page.

Re-uploading; I think the testbots are fixed...

#21: user_register_validate-720876-21.patch queued for re-testing.

Opened related #1192088: The user_register_validate() function is faulty and should be removed.

#21: user_register_validate-720876-21.patch queued for re-testing.

Renaming patch to avoid useless core testing as suggested by ksenzee in IRC.

Opened related #1192178: The user_module_invoke() function lacks documentation of parameters.

So, I've been testing this patch and related code. I think Drupal core masks the error due to the isset() check in function user_user(), so the rest of the code is never called when an anonymous user registers. However, any contrib module implementing hook_user('validate') will see a notice or worse from this bug, and according to the OP PHP 5.3 is less graceful in handling the case of an array accessed as an object.

This test code on PHP 5.2.6 gives me:
FALSE
TRUE

<?php
$x = array();
var_dump(isset($x->uid));
echo "\n";
$x['uid'] = 1;
var_dump(isset($x->uid));
echo "\n";

According to pillarsdotnet PHP 5.3 gives FALSE FALSE which reinforces the fact that 5.2 and 5.3 are different about this.

In any case - the patch is trivial and won't cause any harm and makes core respect its own API.

#21: user_register_validate-720876-21.patch queued for re-testing.

Committed, pushed, thanks.