Insert module support [#717118]

I have created a small patch for enabling insert functionality on swftools content. The new functionality includes one new insert style, called "swfmedia" and labelled "swf media", and inserts the swftools tag, [swf file= "{filename}"], to the content wysiwyg.

The patch adds 2 news files to the module:
* includes/swftools.inc
* templates/swftools-insert-media.tpl.php

Modifications to the insert.module file are simply to include the 2 new files, in functions insert_init() and insert_theme().

Pretty simple stuff, but still might be useful to some.

Comment	File	Size	Author
#1	insert-swftools.patch	2.47 KB	iwayMan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

iwayMan CreditAttribution: iwayMan commented 17 February 2010 at 16:36

File	Size
insert-swftools.patch	2.47 KB

And here is the patch...

Comment #2

lolmaus CreditAttribution: lolmaus commented 24 July 2010 at 18:06

Status:

Needs review

» Reviewed & tested by the community

Worked for me in Insert 6.x-1.0-beta4.

Thanks iwayMan!

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 27 July 2010 at 01:42

Title:	swftools support	» Insert module support
Project:	Insert	» SWF Tools
Version:	6.x-1.x-dev	» 6.x-3.x-dev
Status:	Reviewed & tested by the community	» Needs work

My preference would be to include this in SWFTools rather than Insert. Insert is designed to include only the modules that have been moved to core by default (FileField, ImageField, and ImageCache). As you've noticed, all of the functions are actually scoped so that they could be included directly in the module that provides the content. I'm not a big fan of using tokens instead of the actual HTML code, but with SWFTools I definitely understand why you'd want an input filter instead.

I'll move this over to the SWFTools queue and see what they think over there.