OpenWYSIWYG broken, jWysiwyg needs jQuery 1.3+

Wow, thank you! :)

I'm getting this error from FF Error Console:

Error: The stylesheet node/add/styles/wysiwyg.css was not loaded because its MIME type, "text/html", is not "text/css".
Source File: node/add/forum
Line: 0

Using
IE Unlimited CSS Loader
Might that be the problem??

never mind, uninstalled openwysiwyg and installed FCK. problem solved, 20 minutes.

It's openWYSIWYG problem, they define their own '$' function ...

I replace $( with $openWysiwyg( in scripts/wysiwyg.js and everything works

Can we try this for openWYSIWYG?

The latest version can not detect openWysiwyg:

Library patch is defined as:

  'library path' => wysiwyg_get_path('openwysiwyg') . '/scripts',

while we use

  $changelog = $editor['library path'] . '/changelog';

The change log file stays in editor folder, not the scripts folder :(

And the patch does not work too.

#6 is caused by #752516-10: Version callback failed to open stream

So let's try again? Not sure what $openWysiwyg that has been mentioned in #4 is...

Well its about $ being bind to something else then jquery. But well, you cann use the normal enclosure trick here, which is used to also let jquery plugins work

(function($) {
.
.
.
})(jQuery);

Well in the other case, instead of replacing $ with $openWysiwyg, simply to the same arround the whole editor js implementation.

(function($) {
.
.
.
})($openWysiwyg);

Since D6 does not globally use jQuery.noConflict(); I fear there's little chance to solve this properly prior to D7.

Thus, attached patch reverts the addition of the $ closure in openwysiwyg.js, which worked previously and still works now.

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

That said, I'd welcome feedback on #970892: Drop openWYSIWYG support

Awww, and I was just going to throw another patch in here.

We don't need jQuery.noConflic(). It just reverts $ to what it was before jQuery was loaded, which in our case is undefined since we load openWYSIWYG after jQuery.

Instead of manually overriding methods on the global WYSIWYG object to swap between the versions of $, why not automate it?

// Wrap openWYSIWYG's methods to temporarily use its version of $.  
jQuery.each(WYSIWYG, function (key, value) {
  if (jQuery.isFunction(value)) {
    WYSIWYG[key] = function () {
      var old$ = $;
      $ = Drupal.wysiwyg._openwysiwyg;
      var result = value.apply(this, arguments);
      $ = old$;
      return result;
    };
  }
});

$ = old$; instead of $ = jQuery; makes this temporary replacement survive nested calls to methods without needing a "depth counter" to know when it's safe to revert to jQuery's $.

Crazy TwoD, just crazy :)

XD

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.