This file gives a <div class="warning"> wrapper around the warning message. It should be <div class="messages warning"> to be consitent with other system messages that run through theme_status_messages().

This is one of those PITA things that end up needing to be worked around in the theme layer, and I would like to see it fixed.

Attached is a screenshot demonstrating the problem this causes themers, and a patch to fix.

CommentFileSizeAuthor
Inconsistent classes for system messages.png452.44 KBJacine
tableDragChangedWarning-markup.patch1014 bytesJacine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Reviewed & tested by the community

Yup!

The standard messages have the .messages class, so the blocks JavaScript theming should too.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Good catch. Thanks for the helpful screenshot too. Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.