I've installed Table manager on two Drupal 6 sites and, once a table is created, I don't have the option of ADDing a column. Is this not in the build yet? Apologies if this was covered elsewhere but I wasn't able to find.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfismvg’s picture

Assigned: Unassigned » pfismvg

In general dev version means unfinished. So expect other things not to work as well.

I am working on some updates in the admin interface, allready including this feature.

It is working on my site allready, i just need to do some more testing and cleanup, after that i will post a patch here.

sjz’s picture

Yes - and thanks... I understood the expectation with a "dev" version to be just that ... I just couldn't tell what was / was not ready from the notes.

Thank you for the swift response.

pfismvg’s picture

FileSize
4.52 KB
5.85 KB

OK here is the patch

and for those who dislike using patch a zip file with the updated tables.inc, put this in the include folder

this patch adds the following features in /admin/content/tablemanager/table_edit

* turn sorting off
* add a column/field (existing data will not be changed, so you will need to edit all rows manually to fix... todo: insert blank data)
* reorder fields (again existing data is not modified.... what was in column 1 will stay in column 1 etc... todo: walk trough data and swap)
* enabled changing field type. (probably turned off because your data is not validated, but not being able to change is not really wat most people want)

please test and report bugs back here

pfismvg’s picture

FileSize
4.88 KB
9.01 KB

Another path with all of the above and:

* add a column/field now inserts blank data in your new column
* reordering columns will reorder data too
* deleting a column will delete the actual data in the column
* pressing add or delete no longer resets the weight values

todo:
* "sort order" and "Default sorting" reset their values when you press add or delete

pfismvg’s picture

FileSize
4.92 KB
9.53 KB

Ok done :)

the admin interface now is complete, so i am calling this a releace candidate ;)

* turn sorting off
* add a column/field (existing data will be padded with blank data)
* delete a column wil now also delete data in that column
* reorder fields (existing data will be reorded too)
* enabled changing field type. (probably turned off because your data is not validated, but not being able to change is not really wat most people want)
* pressing add or delete no longer resets the weight, "sort order" and "Default sorting" values

I tested it and it looks pretty stable, lets give it a week before i try to get pobsters attention to merge it.

Please test and provide feedback if this works (or not) and/or if I am missing features that should be there.

pfismvg’s picture

Status: Active » Needs review
sjz’s picture

I've tested the admin updates but noticed a few things:

Once a field is defined, I cannot edit the table and modify validation inputs for things like

  • numeric minima and maxima
  • bar chart options
  • selection box choices
    • Otherwise - Great progress!

pfismvg’s picture

Oops... i have never even seen these extra options

I think they will even be lost on table edit, as they are not processed in the form at all.

I will think about how to put this in the form

pfismvg’s picture

FileSize
12.71 KB
5.25 KB

quick update so you can edit:

  • Bar Chart options high and low
  • Selection Box choices

Numeric minima and maxima dont exist in the code. as far as i can see there are no extra options on a numeric field in this version

I am not sure if this is the most optimal layout, but i put the code online anyway so you can repair your tables if needed.

If anyone has better ideas how this should look / be organized, i am open to your input ;)

pfismvg’s picture

FileSize
13.36 KB
5.94 KB

Another release candidate. (lets hope its right this time)

I tweaked CSS a bit so that it does not look awfull in IE8

* turn sorting off
* added bar chart options
* added selection box choices
* add a column/field (existing data will be padded with blank data)
* delete a column wil now also delete data in that column
* reorder fields (existing data will be reorded too)
* enabled changing field type. (probably turned off because your data is not validated, but not being able to change is not really wat most people want)
* pressing add or delete no longer resets the weight, "sort order" and "Default sorting" values

again... lets give it a week before i try to get pobsters attention to merge it.

Please test and provide feedback if this works (or not) and/or if I am missing features that should be there.

sjz’s picture

I've not had much time to test it but on a preliminary test it looks pretty good! I'll do more testing later.

Thank you!

pfismvg’s picture

Assigned: pfismvg » Unassigned
Status: Needs review » Reviewed & tested by the community

OK..

Used it for a while now and i dont see any problems.

Pobster can you please merge the patch in #10 to 6.x-1.x-dev?

pobster’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Closed (outdated)

Closing as D6.x is now unsupported.