CCK field default value's not getting picked up

Could you find out where exactly CCK populates default values?

Sorry - wasn't clear enough. I meant where it populates the values, not stores them. So on which callback / hook does CCK populate default values on a node? I assume it happens somewhere beneath node_object_prepare() - correct? If so, default values should be present before mapping, but mapping overrides the default values. If not, I'd be curious as to where else default values are being populated.

I wonder if the default was added after the nodes were created. My recollection is in that case the default isn't stored until the node is edited and saved again.

Does the patch here:
http://drupal.org/node/612060

Help with this issue?

Related report: #857216: Behavior on importing empty/NULL/invalid dates

Has anyone found a workaround for this? I would like to create a content type that includes some fields that are imported by Feeds, and other fields that use CCK default values. My default values work fine for nodes that I create manually, however the default values do not appear for nodes that are created by Feeds.

@herd45: this is another scenario than I thought of.

I become aware that there are two cases for default values:
1. mapped cck fields with empty source values should be set to a default value
2. not mapped fields, should also get a default value, your case.

Case 2 is only needed on feed item creation and not on feed item updates. Case 1 however need some special attention for feed item updates: if a feed item is updated and the source value becomes empty, the behavior should be that the target value should fall back to the default value.

To make case 2 happen, we should build a node with all the default values filled.
I think this is working in the node_import.module in node_import.inc. I am not sure about this, but I think there is at the moment a difference between the feeds module and the node_import module in the way nodes are created: feeds doesn't build a node form, but just saves a node, whereas node_import and first build a node form, with default values and with all modules able to hook (like the module automatic nodetitle) and then submit and validates the node.
Is this indeed the case, and if so, is this by design?

I'm attaching a patch which uses default values for all empty values. It should perhaps be optional.

CCK adds the default values to the form and not in a nodeapi_prepare function which is a bit odd. To solve all problems the CCK values should be added in a nodeapi_prepare function - something that CCK itself needs to do, but also such a major change that they probably can't change it in 2.x.

To solve all cases of default values a patch against FeedsNodeProcessor.inc would be needed that exposes a way to add default values that isn't added in a nodeapi_prepare function.

voxpelli: great work.
This patch is a solution for mapped fields (case 1 in #8).

With the proposed patch I see probaly a conflict with #873198: Import multiple values to tag vocabulary. When we have multiple source fields and the first one is empty, I am afraid that the target field becomes incorrectly filled with the default value. What dou you think?

@Hanno: Might be that no default at all is inserted - have to check that out. But we shouldn't be rolling patches that are dependent on each other - right? So lets wait until one of them has been committed and then adjust the other one to accommodate those changes?

I am having the exact problem as the first post in this thread... I see there is some sort of conflict going on between this and another patch? What am I supposed to do? I cant get inherit taxonomy to work to I am trying to set a default cck taxonomy value...

ok I am really stupid. I assumed taxonomy would automatically be inheritted, and not that you have to set the mappings. Works great. Thanks. defualt values of cck fields are not inherited when left empty though.

@voxpelli #873198: Import multiple values to tag vocabulary is now committed , so now we can test what will happen with multiple source fields and your patch #9

#10 is a good point. When andrewlevine and I were working on resetting mapping targets before mapping to them we were talking about a reset callback.

    foreach ($this->config['mappings'] as $mapping) {
      if (isset($targets[$mapping['target']]['real_target'])) {
        unset($target_item->{$targets[$mapping['target']]['real_target']});
      }
      elseif (isset($target_item->{$mapping['target']})) {
        unset($target_item->{$mapping['target']});
      }
    }

Could be:

    foreach ($this->config['mappings'] as $mapping) {
      if (isset($targets[$mapping['target']]['reset_callback'])) {
        $targets[$mapping['target']]['reset_callback']($mapping['target']);
      }
      elseif (isset($targets[$mapping['target']]['real_target'])) {
        unset($target_item->{$targets[$mapping['target']]['real_target']});
      }
      elseif (isset($target_item->{$mapping['target']})) {
        unset($target_item->{$mapping['target']});
      }
    }

that reset callback could be where mappers/content.inc populates defaults. It's kind of a second pass node_object_prepare() :P

I applied patch in #9 and it does not seem to work.

I am using beta9.

After importing RSS feed, value for a content type (text area) is still empty, though I have specified default value for that field.

Any time-line on when this will be fixed? (Case 2 in #8)

Thanks,

I think this also effects computed fields not being generating.

subscribing

New release (beta 10) does not cover this issue yet.

Any timeline for this issue?

Thanks,

If someone updates the patch to address the issues mentioned here then I'm sure it will get accepted. I unfortunately haven't had the time yet as I'm managing very many projects at once right now. As in many opensource projects I think there's no timeline for this - it happens when someone decides to do something about it - feel free to do so :)

Still true in Beta 10.

(I don't know what possessed me, in the previous comment, to change the version that this affects to a previous version. I really did mean to change it to the latest.)

subscribing

subscribing

Subscribing

subscribing, not picking up default version on cck link fields either...

Subscribing. Also, I'm happy to test any patches that get made.