PHP 5.3.1 Support

PHP 5.3.0
Drupal 6.15
Revisioning 6.x-3.4

When viewing the revisions tab:

warning: Parameter 2 to _revisioning_view_edit_access_callback() expected to be a reference, value given in XXXXXX/includes/menu.inc on line 452.

The following patch cleared the issue.

Thanks for the patch doug!
While it may get rid of the error, it seems to me that it also may get rid of some of the functionality, namely the defaulting to view/edit the latest revision when a view/edit link is clicked. This functionality required the node->load_op
I need to implement a better solution that doesn't rely on the &ref.

watching

hello,
can you provide me guys with the easiest way to apply this patch ?

Hey Moosa,
Because it's only 1 character that you have to remove (the ampersand &), the quickest way is to open the file sites/all/modules/revisioning/revisioning.module in an editor and change line 378

function _revisioning_view_edit_access_callback($revision_op, &$node) {

to

function _revisioning_view_edit_access_callback($revision_op, $node) {

Good luck!

Moosa:
Checkout the Drupal Handbook page to apply patches.

thnx RdeBoer, the quick solution solved it, no need for the patch :)

it works fine now, the only place i get this error now is when i click publish on some pending review

warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in C:\xampp\htdocs\drupal\includes\module.inc on line 483.
warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in C:\xampp\htdocs\drupal\includes\module.inc on line 483.

Thanks for reporting Moosa. I'll have to fix that instance too.

Like Moosa, I get thesame error after I publish and no email goes out either.

warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in E:\wamp\www\includes\module.inc on line 483.
warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in E:\wamp\www\includes\module.inc on line 483.

Thanks

Losman

Either check out HEAD from the repository or edit the file revisioning/revisioning_api.inc, line #82 (or thereabouts) to look like this:

function revisioning_revisionapi($op, $node) {

In other words, remove the ampersand that precedes $node.
Please report back whether this worked for you.

ok. its great now, i did change it to function revisioning_revisionapi($op, $node)
and it works fine now.

thanks alot :)

Good to hear! As mentioned this fix is already checked into the repository, so will be included in Revisiioning versions 6.x-3.6 and later.

This is great. It works like a charm.
RdeBoer, this is truly a great system.

Thank you for all your help.

Losman

Thanks for your support Losman. Much appreciated!
Rik