Trying to add a module from http://localhost/drupal-7.x-dev/#overlay=%3Fq%3Dadmin%2Fmodules%2Finstall I get a fatal error.

Fatal error: Call to undefined function ajax_process_form() in /home/clemens/htdocs/drupal-7.x-dev/includes/form.inc on line 1246 

Adding includes/ajax.inc fixes this step.

Is this related with #656782: ajax_process_form() results in settings being returned for elements that aren't re-rendered as part of the AJAX request? Guess not.

CommentFileSizeAuthor
#1 ajax_process_form-704656-2.patch502 bytesclemens.tolboom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

clemens.tolboom’s picture

clemens.tolboom’s picture

Status: Active » Needs review
Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dww’s picture

Component: install system » update.module
Status: Closed (fixed) » Active

I'm not sure this is a good idea, and I'm not sure why we need ajax.inc at all once you land on authorize.php. At that point, there should be *no* AJAX happening anymore, period. I'd like to revisit this bug and figure out what's really going on, not just include more code at authorize.php. Every .inc file we load during authorize.php makes the Update manager more fragile and makes it harder to ever solve #606592: Allow updating core with the update manager. So, generally speaking, any "fix" that involves "just load another .inc file" is probably the wrong fix in authorize.php. ;) Anyway, I'll look at this more closely when I have a chance, but I think we should roll back this patch. We should be completely out of the overlay by the time we hit authorize.php...

clemens.tolboom’s picture

I managed to run through the process by adding a 'FileTransferLocal' to system_filetransfer_backends just to see what happens (dunno how to conf ftpd or sshd). The process uses a batch and thus ajax?

Disabling javascript breaks the protocol form "authorize_filetransfer_form" completely too ;(

(my two cents)

dww’s picture

Hrm, so it's a new requirement that batch.inc depends on ajax.inc? Drat. In that case, this is okay, I guess.

Re: "Disabling javascript breaks the protocol form "authorize_filetransfer_form" completely too ;(" -- yup, known bug:

#609772: Impossible to extend the FileTransfer class system in contrib

Dave Reid’s picture

Status: Active » Fixed

Sounds like this should be marked back as fixed then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.