Cannot create or list menu items with Clean URLs off.

Looks like this might be less related to the Clean URLs being switched off, and more to parse_url() being used on relative paths when saving a menu item containing a fragment/query.

From menu.admin.inc:

/**
 * Validate form values for a menu link being added or edited.
 */
function menu_edit_item_validate($form, &$form_state) {
  $item = &$form_state['values'];
  $normal_path = drupal_get_normal_path($item['link_path']);
  if ($item['link_path'] != $normal_path) {
    drupal_set_message(t('The menu system stores system paths only, but will use the URL alias for display. %link_path has been stored as %normal_path', array('%link_path' => $item['link_path'], '%normal_path' => $normal_path)));
    $item['link_path'] = $normal_path;
  }
  if (!url_is_external($item['link_path'])) {
    $parsed_link = parse_url(url($item['link_path']));

From the php docs for parse_url():

Note: This function doesn't work with relative URLs.

Running parse_url on "node#fragment?query=q" results in

array(2) { ["path"]=>  string(4) "node" ["query"]=>  string(16) "fragment?query=q" } 

Hm, too early for me I guess: fragments go at the end, so "node?query=q#fragment"

Initial report is still valid: I cannot create menu items to "node?query=q#fragment" when clean URLs are disabled. Additionally, even though it seems to work since it was added to the menu validation handler, should we use parse_url on relative URLs even though the manual says it does not work?

Patch for review.

Less whitespace.