Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This would be a setting that toggles on and off in theme settings. I believe JohnAlbin is working on it.
Comment | File | Size | Author |
---|---|---|---|
#11 | bartik.patch | 4.85 KB | aspilicious |
#7 | bartik-with-standard-regions.jpg | 9.74 KB | JohnAlbin |
#7 | bartik-with-all-regions.jpg | 39.54 KB | JohnAlbin |
Comments
Comment #1
Jacinecode: http://github.com/jensimmons/Bartik
Comment #2
JohnAlbinAnd JohnAlbin has finished it. :-)
See Added sample content toggle to Bartik and Added list of links sample content for footer regions.
Comment #3
webchickThis qualifies as "fancy doo-dads that not every core theme will have." Please revert.
Comment #4
JacineOh man! This is HAWT :P
Comment #5
Cliff CreditAttribution: Cliff commented@webchick, should the version for this issue be changed to D8? And should it then be applied to all core themes? Or is it too fancy under any circumstances?
Comment #6
willmoy CreditAttribution: willmoy commentedIt's a real shame about bartik but webchick seemed pretty adamant. This is at least a reasonable feature request for D8 and hopefully someone will step up.
Comment #7
JohnAlbinThe problem with _all_ core themes to date is that they are all have left-center-right column layouts. So switching from the default theme and its block config to a new theme means you get to see all of the new themes regions.
The same is not true of Bartik. By design it has a unique set of regions that are completely empty and collapsed when you switch to it.
Here's the screenshot of Bartik with its regions filled with dummy content:
And here's the screenshot of Bartik with default blocks and no dummy text:
As you can see, Bartik with default blocks really looks… well… un-compelling would be a nice way to say it.
I have no problem with writing patches to give all core themes this functionality. :-D
Comment #8
yoroy CreditAttribution: yoroy commentedThe sample content confused me. Of course I have insider expectations, so that in itself doesn't mean this is a bad idea. I do feel this conflicts with contextual links. With dummy content shown, we get some 'blocks' that are editable, some not. This is what confused me, and I also wondered where the content came from. Yes, that is explained in the actual dummy text, but no, people don't read :)
So I'm not a fan / agree with webchick.
If, *if* this stays:
- It should be off by default. Much nicer to discover this kind of feature instead of having to undo it. Too much in-your-face helpfullness. (I would rather have seen a default node added to the default instal profile but that's another issue)
- The dummy content for the slogan should be shorter.
Comment #9
jensimmons CreditAttribution: jensimmons commentedComment #10
jensimmons CreditAttribution: jensimmons commentedThis can be done by anyone. The original commits that need to be undone are:
http://github.com/JohnAlbin/Bartik/commit/19cb784585db47cb137cf7decb807c...
and
http://github.com/JohnAlbin/Bartik/commit/e68beea194b087c7dc8a990144c47f...
Just manually roll back the code, and create a new CVS patch.
Comment #11
aspilicious CreditAttribution: aspilicious commentedThis needs review+testing.
I didn't test it!
Comment #12
yoroy CreditAttribution: yoroy commentedchange status then :)
Comment #13
jensimmons CreditAttribution: jensimmons commentedThis patch failed. So I'm working on it again.
Comment #14
jensimmons CreditAttribution: jensimmons commentedI made the changes and committed straight from my local. John Albin reviewed after and gave it his blessing.