This would be a setting that toggles on and off in theme settings. I believe JohnAlbin is working on it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jacine’s picture

JohnAlbin’s picture

Status: Active » Fixed
webchick’s picture

Status: Fixed » Needs work

This qualifies as "fancy doo-dads that not every core theme will have." Please revert.

Jacine’s picture

Oh man! This is HAWT :P

Cliff’s picture

@webchick, should the version for this issue be changed to D8? And should it then be applied to all core themes? Or is it too fancy under any circumstances?

willmoy’s picture

Title: Add help text to Bartik that acts as dummy content to show off the region set » Add dummy content to show off the region set
Version: 7.x-dev » 8.x-dev
Component: other » theme system
Status: Needs work » Active
Issue tags: -Bartik

It's a real shame about bartik but webchick seemed pretty adamant. This is at least a reasonable feature request for D8 and hopefully someone will step up.

JohnAlbin’s picture

Title: Add dummy content to show off the region set » Add/remove dummy content to show off the region set
Project: Drupal core » Bartik
Version: 8.x-dev » 7.x-1.x-dev
Component: theme system » Code
Assigned: Unassigned » JohnAlbin
FileSize
39.54 KB
9.74 KB

The problem with _all_ core themes to date is that they are all have left-center-right column layouts. So switching from the default theme and its block config to a new theme means you get to see all of the new themes regions.

The same is not true of Bartik. By design it has a unique set of regions that are completely empty and collapsed when you switch to it.

Here's the screenshot of Bartik with its regions filled with dummy content:

And here's the screenshot of Bartik with default blocks and no dummy text:

As you can see, Bartik with default blocks really looks… well… un-compelling would be a nice way to say it.

This qualifies as "fancy doo-dads that not every core theme will have."

I have no problem with writing patches to give all core themes this functionality. :-D

yoroy’s picture

The sample content confused me. Of course I have insider expectations, so that in itself doesn't mean this is a bad idea. I do feel this conflicts with contextual links. With dummy content shown, we get some 'blocks' that are editable, some not. This is what confused me, and I also wondered where the content came from. Yes, that is explained in the actual dummy text, but no, people don't read :)

So I'm not a fan / agree with webchick.

If, *if* this stays:
- It should be off by default. Much nicer to discover this kind of feature instead of having to undo it. Too much in-your-face helpfullness. (I would rather have seen a default node added to the default instal profile but that's another issue)
- The dummy content for the slogan should be shorter.

jensimmons’s picture

Priority: Normal » Critical
jensimmons’s picture

Assigned: JohnAlbin » Unassigned
Status: Active » Needs work

This can be done by anyone. The original commits that need to be undone are:
http://github.com/JohnAlbin/Bartik/commit/19cb784585db47cb137cf7decb807c...
and
http://github.com/JohnAlbin/Bartik/commit/e68beea194b087c7dc8a990144c47f...

Just manually roll back the code, and create a new CVS patch.

aspilicious’s picture

FileSize
4.85 KB

This needs review+testing.

I didn't test it!

yoroy’s picture

Status: Needs work » Needs review

change status then :)

jensimmons’s picture

Status: Needs review » Needs work

This patch failed. So I'm working on it again.

jensimmons’s picture

Status: Needs work » Fixed

I made the changes and committed straight from my local. John Albin reviewed after and gave it his blessing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.