Hi guys.

I found a strange error in the site menu code that I can't quite track down.

The code generated is:

<div id="site-menu" class="grid-12">
<div>
<ul class="links main-menu">
<li class="menu-237 first">
</li>
<li class="menu-229 last">
</li>
</ul>
</div>
<div/>

Note the last end div call. This leads to heaps of issues.

I've gone through the page.tpl.php file, and the close site menu div tag is correct:

<?php if ($main_menu_links || $secondary_menu_links): ?>
        <div id="site-menu" class="grid-<?php print $header_menu_width; ?>">
          <div><?php print $main_menu_links; ?></div>
          <div><?php print $secondary_menu_links; ?></div>
        </div><!-- /#site-menu -->
      <?php endif; ?>

Any idea what the cause is?

Comments

DanGarthwaite’s picture

I thought I'd find it in omega/preprocess/preprocess-page.inc, but didn't.

himerus’s picture

Issue tags: +6.x-1.0-beta1

sorry for a slow response here.... what this is is actually the fact that there isn't a if statement before the divs that contain the main and secondary menus.

so an empty secondary menu would generate an open and close div tag, but html correctors would change it to what you are seeing.

This is fixed in beta-1 that will be released shortly.

himerus’s picture

Status: Active » Fixed

This has been fixed and committed in the 6.x-1.0-beta1 release. You can download this version here.

bigkevracer’s picture

awesome. Thanks :D

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.0-beta1

Automatically closed -- issue fixed for 2 weeks with no activity.