Hi !

The theme_emvideo_flickr_sets_flash function located in providers/emvideo does not generate valid XHTML 1 markup for the Flash slideshow since it uses the embed tag and param are not correctly closed.

I tried the following code under Firefox and IE6 and it seems to work well while being XHTML 1 valid.

    $output = <<<EMBED
<object type="application/x-shockwave-flash" data="http://www.flickr.com/apps/slideshow/show.swf?v=71649" width="$width" height="$height">
  <param name="movie" value="http://www.flickr.com/apps/slideshow/show.swf?v=71649" />
  <param name="flashvars" value="offsite=true&amp;lang=en-us&amp;page_show_url=/$embed/show/&amp;page_show_back_url=/$embed&amp;set_id={$item['value']}&amp;jump_to=" />
  <param name="allowFullScreen" value="true" />
</object>
EMBED;

Code may need additional testing under Chrome or Safari.

Workaround for the time being is to override the function in template.php in order to include the above code.

Comments

aaron’s picture

Status: Active » Fixed

thanks; got it!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.