Standardize there names and meanings, and add prefixes to make them easier to document which plugins (or all) that they apply.

simpletest.tests
coder.reviews
global.directory
Files: 
CommentFileSizeAuthor
#9 696434-standard-arguments.patch30.69 KBboombatower
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 696434-standard-arguments_4.patch. View
#8 696434-standard-arguments.patch34.21 KBboombatower
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View
#6 696434-standard-arguments.patch34.11 KBboombatower
FAILED: [[SimpleTest]]: [MySQL] 282 pass(es), 1 fail(s), and 0 exception(es). View
#5 696434-standard-arguments.patch30.14 KBboombatower
FAILED: [[SimpleTest]]: [MySQL] 282 pass(es), 1 fail(s), and 0 exception(es). View
#4 696434-standard-arguments.patch30.31 KBboombatower
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View
#3 696434-standard-arguments.patch18.14 KBboombatower
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View

Comments

boombatower’s picture

Assigned: Unassigned » boombatower

Current arguments:

pifr_drupal:
  'core' => 7,
  'database' => 'mysql-5.0-isam',
  'modules' => array(),
  'core-url' => '',

pifr_coder:
  'modules' => array(),
  'directory' => '',
  'pifr_coder.annotate' => FALSE,

pifr_simpletest:
  'core' => 7,
  'tests' => array(),
  'modules' => array(),
  'directory' => '',
  'clone-db' => '',

other:
  'test.title' => '',

Obviously latter two override pifr_drupal base...and database arugment needs to be removed.

boombatower’s picture

Lets shoot for something like:

'test.title' => NULL,
'test.directory.review' => '',
'test.directory.apply' => '',
'test.directory.dependency' => '',
'test.files' => array(),
'test.extensions' => array(),

'drupal.core.version' => 7,
'drupal.core.url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal/drupal',
'drupal.modules' => array(),
'drupal.user' => 'admin',
'drupal.pass' => NULL,

'coder.annotate' => FALSE,

'simpletest.tests' => array(),
'simpletest.db' => NULL,

EDIT: Updated several times.

boombatower’s picture

Status: Active » Needs review
FileSize
18.14 KB
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View

This patch should do it, but I'm looking into more generic implementations of test.* in client.inc instead of drupal/coder/simpletest clients.

boombatower’s picture

FileSize
30.31 KB
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View

Shift code around to fit new argument design, added some new useful arguments, replaced some class variables with arguments, updated debug test arrays, added update path, and fixed a few two bugs in code related to these arguments.

boombatower’s picture

FileSize
30.14 KB
FAILED: [[SimpleTest]]: [MySQL] 282 pass(es), 1 fail(s), and 0 exception(es). View

Updated the client plugin tests, which do not run on but...thus no fail until I ran them locally.

boombatower’s picture

FileSize
34.11 KB
FAILED: [[SimpleTest]]: [MySQL] 282 pass(es), 1 fail(s), and 0 exception(es). View

Another test fix.

Status: Needs review » Needs work

The last submitted patch, 696434-standard-arguments.patch, failed testing.

boombatower’s picture

Status: Needs work » Needs review
FileSize
34.21 KB
PASSED: [[SimpleTest]]: [MySQL] 283 pass(es). View
boombatower’s picture

FileSize
30.69 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 696434-standard-arguments_4.patch. View

Final tweaks to test.

boombatower’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.