Hi,

I recognized, that the deletion of existing order products has been removed from uc_order_save().

http://drupalcode.org/viewvc/drupal/contributions/modules/ubercart/uc_or...

The problem I had with this once was (not retested with latest branch), that if you have some order products in cart and go to checkout page, with the following actions the order products are multiplied after eliminating the deletion-code-line:

go to order review page -> go back to checkout-page -> go to review -> go back to checkout -> go to review ....

Of course the deletion of order products makes no sense, if the order has been created once and is saved again e.g. by an admin-edit-action.

So I added the following patch in my code, which caused no known problems:

if (isset($_SESSION['checkout_valid'])){
db_query("DELETE FROM {uc_order_products} WHERE order_id = %d", $order->order_id);
}

May be the mentioned problem was solved in another way in lastest branch and my issue is needles.

Comments

TR’s picture

Status: Needs work » Closed (won't fix)

You need to try 6.x-2.2 and see if the problem still exist, then re-open this issue if it does. I don't think anyone is going to spend time trying to reproduce a problem in a pre-release version of Ubercart.