Drush make git download fallback to non-private url [#688648]

This patch allows drush_make to fallback to a public url if the private one fails. This is useful for our projects where github.com has both private and public urls, and all of the programmers don't have or need contributor access to every project. This way the project downloads as an export if it can't do so as a checkout. Working, tested simple patch attached.

Thanks,
David

Comment	File	Size	Author
	drush_make-gitfallback.patch	2.24 KB	David Goode

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dmitrig01 CreditAttribution: dmitrig01 commented 19 January 2010 at 05:08

Please use parse_url instead of whatever magic you're using -- thanks!

Comment #2

David Goode CreditAttribution: David Goode commented 20 January 2010 at 20:55

parse_url doesn't work properly on github's urls. This is the only git repos I've used drush make with--if there are other different url or transport formats we should support, input would be appreciated. The public and private versions, respectively, are "git://github.com/developmentseed/mn_world.git" and "git@github.com:developmentseed/mn_world.git". The former parses reasonably, but parse url can't do anything with the latter, just returning the 'path' as the entire thing, so using the built-in php function would still require some str_replacing and add'l logic to get it to a viable format, which probably isn't worthwhile.