Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Attached is a patch to improve devel's FirePHP integration to output watchdog entries to the console of FireBug automatically, if FirePHP was available.
Comment | File | Size | Author |
---|---|---|---|
#10 | devel-firephp-watchdog-6.patch | 4.69 KB | jurgenhaas |
#9 | devel-firephp-watchdog-5.patch | 4.79 KB | jurgenhaas |
#5 | devel-firephp-watchdog-4.patch | 637 bytes | jurgenhaas |
#2 | devel-firephp-watchdog-3.patch | 2.09 KB | jurgenhaas |
#1 | devel-firephp-watchdog-2.patch | 2.09 KB | jurgenhaas |
Comments
Comment #1
jurgenhaasRe-rolled the patch to cover a scenario where a watchdog gets output before the first dfb() call.
Comment #2
jurgenhaasRe-rolled tha patch for the latest dev release of Devel.
Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedcommitted, with some massaging of the message so it cleanly shows the text.
thanks. i was wondering if anyone even noticed this nice integration. if folks have not tried out firephp, its really slick.
Comment #4
jurgenhaasYes, you're right. It saves a ton of time. Thanks for taking this on. Shall we do a bit more work on this? Like grouping and exception handling. I'm happy to do that if you're interested in it.
Comment #5
jurgenhaasSorry, I reopened this issue because the message handling isn't quite clear to me. You replaced tha call to t() with a call to strtr() but the latter doesn't translate the message, does it?
Also, there was a possible issue with the variables array not being set and causing another error. Both is fixed in the applied patch. Please have a look and let me know what you think.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedgood work on variables fix. TRUE, but t() is only available after bootstrap_full so we need to: function_exists('t') ? t() : strtr()
sure, i'm interested in seeing enhancements for excpetions and groups (what are those?) ... i could even go for sending the $form and $form_state data structures for every $form on the page. Just listen on form_alter hook. we are now encroaching upon drupal for firebug module but that one is not actively maintained/ i think some competition here is healthy.
Comment #7
jurgenhaasQuite right. I'll put the function_exist in later today, together with a proposal (or first implementation) of groups and exceptions. Groups btw. are a possibility to group fb() messages together in groups so that you get a better overview in FireBug console and only expand those entrie/groups that you're interested in.
Regarding forms, that's an excellent idea. Shouldn't be too difficult to implement. But then you probably want a link in the devel menu to toggle that feature on/off as it may cause a lot of output.
Comment #8
moshe weitzman CreditAttribution: moshe weitzman commentedFYI, I'm open to breaking out the FirePHP code into a separate module. We can then discuss if that module should be in devel package or independant.
Comment #9
jurgenhaasThis patch is against the latest dev release of Devel and you can call this a complete FirePHP integration. It allows groups and all other things (get and set options, etc.) as well as outputting forms from hook_form_alter().
Regarding a splin-off I suggest we probably wait for that until we've seen what happens to FirePHP 1.0 which is in the pipeline. Then it will be called FireConsole and it may well be a completely different product. Then it may well make sense to have that separated (but still packed with devel?).
Comment #10
jurgenhaasRe-rolled the patch against the latest dev-release of Devel.
Comment #11
moshe weitzman CreditAttribution: moshe weitzman commentedIf we are going to do such a complete implementation, I think we need to make this an independant module now. I also think it should be a separate project on drupal.org. If you are willing to maintain it, thats great. If not, I guess it can live in devel for a while.
Comment #13
willzyx CreditAttribution: willzyx commentedClosing for lack of activity. Feel free to reopen if the issue still exists