It currently only compares with either the internal path or the aliased path rather than both. i.e. the result of drupal_get_path_alias($_GET['q']);.

Patch attached.

Thanks,
-K

CommentFileSizeAuthor
block_visibility_1.patch1.34 KBZen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I just marked http://drupal.org/node/69346 as a duplicate of this issue. It's confusing to users and this seems like a handy idea.

The concern I have is related to the performance of adding this extra check, but that seems like a minor issue.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Version: 4.7.2 » x.y.z

moving to cvs, will backport if this gets applied. I generally think this is a good idea. Question is how much performance penalty we get.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)
Zen’s picture

Zen CreditAttribution: Zen commented
Version: x.y.z » 4.7.4
Status: Closed (fixed) » Reviewed & tested by the community

This needs to be applied to 4-7 as well. Patch still applies with an offset.

-K

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

backported

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)