Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It's baaaaaaack... :\
There have been quite a few improvements to Overlay module lately (yay!) so I'm not sure when exactly this was re-introduced. (boo!)
My left lung for the ability to write tests for JS interaction like this so we don't continue to break this repeatedly... :\
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | no-shortcut-1.patch | 579 bytes | alpritt |
Comments
Comment #1
casey CreditAttribution: casey commentedUh oh, I think it isn't javascript what is causing this. Try adding another shortcut... Both shortcuts will appear.
Or try with overlay disabled... Not working either.
Wild guess: I think this has something to do with drupal_render cache
Comment #2
casey CreditAttribution: casey commentedIsn't drupal_render cache per theme?
Comment #3
casey CreditAttribution: casey commentedComment #4
alpritt CreditAttribution: alpritt commentedIt gets confused with menu depth. Needs test, and probably a comment too.
Comment #5
alpritt CreditAttribution: alpritt commentedComment #6
jascott CreditAttribution: jascott commentedThis fixed the problem for me. It looks like one line.
$link['plid'] = 0;
Does it need a comment?
Comment #7
webchickOMG! Great find!
I decided to create a sub-issue for tests over here: #680850: Tests for Shortcut module, just in the interest of whipping through some of these critical issues in Shortcut module before Alpha.
I have no idea how in the heck you figured that out, but I agree that a comment is probably unnecessary once we have test coverage.
Therefore, marking this fixed. THANKS!!