function array-merge

This is what I found, which makes me refile it as a bug vs. menu.inc.

The menu item in week.module that causes the problem:

function week_menu() {
  $items[] = array('path' => 'week', 'title' => t('weekly archives'),
    'callback' => '_week_page', 'type' => MENU_CALLBACK,
    'access' => user_access('access content'));
  return $items;
}

And the section of menu.inc the error message is complaining about:

  // We found one, and are allowed to execute it.
  $arguments = array_key_exists('callback arguments', $menu['items'][$mid]) ? $menu['items'][$mid]['callback arguments'] : array();
  $arg = substr($_GET['q'], strlen($menu['items'][$mid]['path']) + 1);
  if (strlen($arg)) {
    $arguments = array_merge($arguments, explode('/', $arg)); // line 351
  }

I'm not passing callback arguments. This section of code assumes I am, and PHP5 is a lot more sensitive about that sort of thing.

I offer the attached patch.

Will commit if someone can reproduce the problem, and confirm that this fixes the issue.

There should only be an error happening if the value for 'callback arguments' is not an array. The relevant code from HEAD:

 // We found one, and are allowed to execute it.
  $arguments = isset($menu['callbacks'][$path]['callback arguments']) ? $menu['callbacks'][$path]['callback arguments'] : array();
  $arg = substr($_GET['q'], strlen($path) + 1);
  if (strlen($arg)) {
    $arguments = array_merge($arguments, explode('/', $arg));
  }

So the patch just hides the error. We might check if it's an array and produce a helpful error message. But it should never be the case that 'callback arguments' is NOT set and an error occurs here.

Okay. This should be acceptable

  // We found one, and are allowed to execute it.
  $arguments = isset($menu['items'][$mid]['callback arguments']) ? $menu['items'][$mid]['callback arguments'] : array();
  $arg = substr($_GET['q'], strlen($menu['items'][$mid]['path']) + 1);
  if (strlen($arg)) {
    $arguments = array_merge($arguments, explode('/', $arg));
  }

I use isset() because the only way the original code could fail is if $menu['items'][$mid]['callback arguments'] is set but equals NULL.

I have no clue how that might have happened.

How to reproduce?
Also, if it's a bug, it should be fixed in cvs first, and backported soon after.

Promotheus: how does that fix the problem? Or how would that affect the offending module?

The problem is that a module is incorrectly using the callback mechanism. Could you post the code of the offending module, so we can grok the problem a little bit better?

Nevermind, I figured it out by looking a bit closer to the previous comments.

Patch does not apply against CVS HEAD.

The patch was submitted against 4.6.8, not CVS, and should still apply.

Precisely: as I said in #5!

The bug exists in 4.6.8. It does not exist in cvs. Check #3, please.

Or don't fix the bug.

You say the bug doesn't exist in 4.7 and HEAD?
Please accept my apologies.

Done, of course

Dries already commented on this one.
Also, I checked, this would indeed be a backport of a bug that is already fixed in 4.7 and cvs.

the patch I attached, is basically the same as the previous one, but conforms better to the patch guidelines.

Patch no longer applies.

I just checked, it does apply.
This must be applied to the 4-6 branch!

Oops, you're right. Committed to CVS HEAD. Thanks.

Erm, committed to DRUPAL-4-6.

:) thanks.