Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
improvements:
1. SC variables created from taxonomy terms moved to sub-module
2. new SC variables (in sub-module): page title, user name
Comment | File | Size | Author |
---|---|---|---|
#8 | 679320-8-D7_port_omniture.patch | 4.07 KB | Pasqualle |
D7_port_omniture.patch | 27.42 KB | Pasqualle | |
Comments
Comment #1
Pasquallepatched version: [EDIT: download link removed]
Comment #2
Pasquallein omniture_basic.module
'und'
should be replaced withLANGUAGE_NONE
Comment #3
PasqualleComment #4
gregglesAwesome - thanks Pasqualle. I'm not using the module and so not in a position to test this out right now. Pending a review from someone who is using it I could also just commit this and make a dev release to help others testing it.
Comment #5
Race.it CreditAttribution: Race.it commentedIf I get chance ill review tomorrow, there are another couple I need to review also.
Comment #6
Pasquallethe original patch was not fully committed.
problems:
function omniture_page_alter()
wrong function description
this must be ||
function omniture_admin_settings()
old value; should be H.20.3
typo
remove unused variable
replace with '#title' => $role_name,
remove trailing spaces..
please remove .project file from cvs (from all branches)
Comment #7
gregglesCan you provide a new patch?
Comment #8
Pasquallesure
Comment #9
Race.it CreditAttribution: Race.it commentedI have commited this change, I did notice one issue thought and that was with the page_alter() function, and its been updated to work with php 5.3
A new dev version should be rebuilt shortly for testing.
Comment #15
Pasqualle