The Add New Block page (admin/structure/block/add) has at least one minor UI text issue:

"A brief description of your block. Used on the blocks administration page."

Page titles are capitalized. Should say "Blocks administration page". (it's already a link, which is good, so it probably doesn't need an EM or other HTML added to it).

CommentFileSizeAuthor
#7 677562.patch2.58 KBjhodgdon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Farther down on that page, in the Content Types options page, it says:
"Show this block only on pages that display content of the given type(s). If you select no types, there will be no type specific limitation.".

Should be type-specific (with a hyphen).

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

The "Users" section at the bottom:

Customizable per user
Not customizable
Customizable, visible by default
Customizable, hidden by default
Allow individual users to customize the visibility of this block in their account settings.

I thought we were using the verb "edit" instead of "customize"?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Oh, and one more thing. If you have the Help module on and the Help block on, you'll see the following help at the top of the screen:

"Use this page to create a new custom block. New blocks are disabled by default, and must be moved to a region on the Blocks administration page to be visible."

But there's a section right there on the editing screen you're looking at that lets you assign it to a region. So this help text needs an update.

Should probably say:

"Blocks must be assigned to a region, either below or on the (link)Blocks administration page(endlink), to be visible."

yoroy’s picture

yoroy CreditAttribution: yoroy commented

Oh dear. how about contradicting myself huh? :) I think sun and I chose 'customizable' here because we're in a sea of 'edit' options here.

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Component: block.module » user interface text 
Blocks must be assigned to a region

Dont' use 'must' in user-facing texts.

suggest: 'Blocks are assigned to a region'

now:

Use this page to create a new custom block. New blocks are disabled by default, and must be moved to a region on the Blocks administration page to be visible.

suggest:

New blocks are disabled by default, assign them to a region on the Blocks administration page to be visible.
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Don't combine two sentences with a comma. Use a semi-colon or a period. Please.

That aside, since you can assign them to a region on the page you are looking at, right below, I don't like implying that you ahve to go to the blocks admin page to assign them. And I also don't really like saying "New blocks are disabled by default". Just tell them that to be visible they have to be assigned to a region, and tell them they can do it either below or on the blocks page.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Active » Needs review
FileSize
677562.patch2.58 KB

Here's a patch to address the issues here, with the exception of Customize, which I left alone as per #4.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

I committed #7 to CVS HEAD. Setting this back to 'needs work' so we can worry about #4, if desired.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Fixed

As per #2/#4, I think I concur with yoroy that the options in the Visibility/Users section of the Add Block page are OK. I had only brought it up because on IRC on Wednesday yoroy was saying that we were trying to not use "Customize xyz" links, and instead we're using "Edit xyz" (see #677534: Customize still being used in place of Edit, for instance).

But these are not links, these are radio button options, and I think trying to change the wording from "customize" to "edit" would be difficult/awkward. It's currently (inside Visibility Options / Users vertical tab):

Customizable per user

(*) Not customizable
( ) Customizable, visible by default
( ) Customizable, hidden by default
Allow individual users to customize the visibility of this block in their account settings.

My opinion: This is clear, let's keep it. Anyone who disagrees can reopen and propose a better wording. :)

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller commented
Status: Fixed » Needs work

Unless Drupal 7 adding blocks form is radically different from Drupal 6, the text that was committed is confusing and unfortunately misleading.

+      return '<p>' . t('Use this page to create a new custom block. New blocks are disabled by default; assign them to a region, on this page or the <a href="@blocks">Blocks administration page</a>, to make them visible.', array('@blocks' => url('admin/structure/block'))) . '</p>';

There are two parts to block visibility, each can be set on different forms, neither can be set on one:

  1. Region placement: Blocks administration page
  2. Block Visibility: Blocks add / edit form

Here's my issue with this text. You can set the block to be visible, but until you click "save" and then set the region and click "save" again, you will not have a visible block. It has to be in this order. In fact, the link to the Blocks administration page is misleading because you actually have to save this new block before you can modify it's region placement. Why on earth would they click on a link and completely hose what they've added thus far?

Sorry to be annoying about it and not produce a patch... I really don't know what to write to satisfy the actual steps.

Josh

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Fixed

Region placement *is* on the Drupal 7 block add/edit form. THat is why we changed the text to reflect this.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller commented

Open mouth, insert foot... jhodgdon on #3: "But there's a section right there on the editing screen you're looking at that lets you assign it to a region. So this help text needs an update."

I love Drupal 7. Sounds like the blocks add form got some makeover love.

Given that, my only gripe is that the link could confuse some folks.

Sorry to be annoying. I should read every bit of text before I shoot my mouth off about stuff I only know well in D6.

Josh

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Why do you think the link will confuse people? There are two ways to assign to a region...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.