Customize still being used in place of Edit [#677534]

Comment	File	Size	Author
#29	677534onemore.patch	10.94 KB	jhodgdon

#27	677534tweaked.patch	10.94 KB	jhodgdon

#20	677534more.patch	10.92 KB	jhodgdon

#15	remove.customize.677534.patch	6.36 KB	andrewmacpherson

#14	remove.customize-677534.patch	5.41 KB	andrewmacpherson

#10	removing.customize.patch	4.89 KB	Bojhan

Comment #1

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 01:05

Issue tags:

+ui-text

forgot the tag

Log in or register to post comments

Comment #2

yoroy CreditAttribution: yoroy commented 7 January 2010 at 01:39

Component:	other	» user interface text
Issue tags:	-ui-text

'Customize' was introduced in the UI with dashboard. We want to use 'Edit [thing(s)]' whenever possible. For consistency and using simple words.

See http://drupal.org/node/663906 comment 16/17

Log in or register to post comments

Comment #3

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 02:16

Issue tags:

+ui-text

Why did you remove the tag? I hope it was a mistake.

Log in or register to post comments

Comment #4

yoroy CreditAttribution: yoroy commented 7 January 2010 at 02:44

was thinking the 'user interface text' component is enough?

or like it says below the Tags textfield: "Do NOT use tags for duplicating the "Assigned" or "Component" fields."

Log in or register to post comments

Comment #5

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 14:26

Component:

user interface text

» dashboard.module

The component should have been left at Dashboard, since it's a bug in the Dashboard. The tag is being used actively to find issues by the doc team.

I would only suggest using component user interface text if there is an issue that spans a bunch of modules.

Log in or register to post comments

Comment #6

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 15:03

Component:

dashboard.module

» user interface text

Sorry, I forgot this is an issue that spans several modules. Not awake yet this morning...

Log in or register to post comments

Comment #7

Bojhan CreditAttribution: Bojhan commented 7 January 2010 at 17:20

Yes, this should be standardized - I font think there is any particular win using Customize over Edit. Customize has a small nuance difference implying editing something existing, but I doubt that will cause any usability problems. Lets standardize this, I wouldn't want contrib to start following this - and suddenly using customize when its often not needed.

Log in or register to post comments

Comment #8

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 17:38

Bojhan: Just to confirm, are you saying that all of these places should be using "Edit"? If so, that is something definite that can be patched.

Log in or register to post comments

Comment #10

Bojhan CreditAttribution: Bojhan commented 7 January 2010 at 21:20

File	Size
removing.customize.patch	4.89 KB

There we go removed, a couple notices of it - not sure it didn't take effect on the strings mentioned. Perhaps its coming from the url?

Indeed using edit, though at the dashboard it would probably be Edit dashboard instead of just Edit.

Log in or register to post comments

Comment #11

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 7 January 2010 at 23:29

Status:

Active

» Needs work

If you're going to modify this string in dashboard "This dashboard region is empty, click Edit dashboard to add blocks to it.", please remove the comma splice (it is not correct in English to stick two sentences together with a comma - use period or semicolon). Also, I think Edit dashboard in this sentence needs EM or some other HTML markup.

Also, what about all of those email message customize strings on admin/config/people/accounts down at the bottom?

Log in or register to post comments

Comment #12

Bojhan CreditAttribution: Bojhan commented 8 January 2010 at 00:04

Yhea, that should be edited to - I was still somewhat confused why the string on Shortcuts and Dashboard wouldn't actually change

Log in or register to post comments

Comment #13

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 11 January 2010 at 21:31

#12: You have to go to the Performance config page and clear the cache to see changes in a hook_menu() change like this.

So are you saying that the email message customize strings should say "edit" rather than "customize" too?

Log in or register to post comments

Comment #14

andrewmacpherson CreditAttribution: andrewmacpherson commented 12 January 2010 at 18:40

Status:

Needs work

» Needs review

File	Size
remove.customize-677534.patch	5.41 KB

re-roll of the changes in #10.

the comma-splice concern from #11 is fixed.

Log in or register to post comments

Comment #15

andrewmacpherson CreditAttribution: andrewmacpherson commented 12 January 2010 at 18:52

File	Size
remove.customize.677534.patch	6.36 KB

re-roll of patch in #14

there was a 'Customize' UI string in dashboard.js as well...

Log in or register to post comments

Comment #16

aspilicious CreditAttribution: aspilicious commented 12 January 2010 at 19:03

I just tried to apply patch, it works and I can't find any customize string (searched for 2 minutes). If this becomes green I'll put this RTBC.
Or is there someone finding more "customize" 's?

Log in or register to post comments

Comment #17

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 12 January 2010 at 19:14

Status:

Needs review

» Needs work

There are problem swith this patch -- not introduced in this patch, but still need to be fixed:

1)

-    '#message' => t('To customize the dashboard page, move blocks to the dashboard regions on !block-admin, or enable JavaScript on this page to use the drag-and-drop interface.', array('!block-admin' => l('the block administration page', 'admin/structure/block'))),
+    '#message' => t('To edit the dashboard page, move blocks to the dashboard regions on !block-admin, or enable JavaScript on this page to use the drag-and-drop interface.', array('!block-admin' => l('the block administration page', 'admin/structure/block'))),

There is text here that cannot be translated. Also we are capitalizing names of pages, and the page is called "Blocks".

So this should be:

 '#message' => t('To edit the dashboard page, move blocks to the dashboard regions on the <a href="@blocks">Blocks administration page</a>, or enable JavaScript on this page to use the drag-and-drop interface.', array('!blocks' => url('admin/structure/block'))),

(untested but should work).

2)
"Your are now using the new %set_name shortcut set." -- > should be "You are...".

Log in or register to post comments

Comment #18

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 12 January 2010 at 19:18

This patch also doesn't take care of item (c) from the original report:

User email settings all say "Customize the ...". These are on admin/config/people/accounts down at the bottom.

Log in or register to post comments

Comment #19

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 12 January 2010 at 19:24

I'll make a new patch...

Log in or register to post comments

Comment #20

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 12 January 2010 at 19:33

Status:

Needs work

» Needs review

File	Size
677534more.patch	10.92 KB

Here's a new patch, which also fixes the email editing vertical tabs.

Log in or register to post comments

Comment #21

Bojhan CreditAttribution: Bojhan commented 12 January 2010 at 23:35

Status:

Needs review

» Reviewed & tested by the community

It works

Log in or register to post comments

Comment #22

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 13 January 2010 at 04:40

Status:

Reviewed & tested by the community

» Needs review

I agree with all of these except Dashboard. "Edit dashboard" sounds very awkward to me. I would expect that to let me change the regions, etc. like in Panels, but it does not. I think what we are doing there is actually customizing, as opposed to the other instances.

What say you?

Log in or register to post comments

Comment #23

andrewmacpherson CreditAttribution: andrewmacpherson commented 13 January 2010 at 10:16

the edit dashboard link could keep the word customize, but should be more than one word.

Customize dashboard display
Choose dashboard blocks
Select dashboard blocks
Enable/disable dashboard blocks

Log in or register to post comments

Comment #24

Bojhan CreditAttribution: Bojhan commented 13 January 2010 at 11:23

@webchick I am not sure, I agree that Edit dashboard sounds a bit wierd to the mental model of Panels context. But almost everywhere we use "Edit" to describe editing a certain object - no matter what interaction follows. Perhaps its the location, that makes me sad - rather then the word Customize on its own, but I do not feel that "Customize" on itself is descriptive enough. And Customize dashboard, gets a bit lengthy.

Log in or register to post comments

Comment #25

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 13 January 2010 at 15:52

How about "Configure dashboard"?

I agree with webchick that "edit dashboard" doesn't make sense to me either. "edit" to me has the connotation of changing text, and that's not what you do when you configure the dashboard.

Log in or register to post comments

Comment #26

andrewmacpherson CreditAttribution: andrewmacpherson commented 13 January 2010 at 15:55

+1 for configure dashboard

Log in or register to post comments

Comment #27

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 13 January 2010 at 16:47

File	Size
677534tweaked.patch	10.94 KB

Here's a patch with "Configure dashboard".

Log in or register to post comments

Comment #28

Bojhan CreditAttribution: Bojhan commented 13 January 2010 at 16:59

Give the short amount of time, I don't want us to go backwards. Configure causes a completely different mental model, and so does edit. Also configure its mental weight is high, it means configuring heavy things. Lets keep it to customize then, and add "Customize dashboard" to keep it more clear.