Apparently we've (mostly) standardized in Drupal 7 on the use of the word "Edit" or phrase "Edit settings", rather than Customize.
But there are still a couple of places where Customize appears:
a) Dashboard - admin/dashboard - link says "Customize". Should apparently be "Edit". See also http://drupal.org/node/663906#comment-2436792
b) Shortcut editing - admin/config/system/shortcut/%name - page title is Customize shortcuts. Also, the permissions are called "Customize..."... should that be changed?
c) User email settings all say "Customize the ...". These are on admin/config/people/accounts down at the bottom.
There are some other uses of the word "Customize" in help and messages, but maybe they are OK... I am not sure what the standard is?
Comment | File | Size | Author |
---|---|---|---|
#29 | 677534onemore.patch | 10.94 KB | jhodgdon |
#27 | 677534tweaked.patch | 10.94 KB | jhodgdon |
#20 | 677534more.patch | 10.92 KB | jhodgdon |
#15 | remove.customize.677534.patch | 6.36 KB | andrewmacpherson |
#14 | remove.customize-677534.patch | 5.41 KB | andrewmacpherson |
Comments
Comment #1
jhodgdonforgot the tag
Comment #2
yoroy CreditAttribution: yoroy commented'Customize' was introduced in the UI with dashboard. We want to use 'Edit [thing(s)]' whenever possible. For consistency and using simple words.
See http://drupal.org/node/663906 comment 16/17
Comment #3
jhodgdonWhy did you remove the tag? I hope it was a mistake.
Comment #4
yoroy CreditAttribution: yoroy commentedwas thinking the 'user interface text' component is enough?
or like it says below the Tags textfield: "Do NOT use tags for duplicating the "Assigned" or "Component" fields."
Comment #5
jhodgdonThe component should have been left at Dashboard, since it's a bug in the Dashboard. The tag is being used actively to find issues by the doc team.
I would only suggest using component user interface text if there is an issue that spans a bunch of modules.
Comment #6
jhodgdonSorry, I forgot this is an issue that spans several modules. Not awake yet this morning...
Comment #7
Bojhan CreditAttribution: Bojhan commentedYes, this should be standardized - I font think there is any particular win using Customize over Edit. Customize has a small nuance difference implying editing something existing, but I doubt that will cause any usability problems. Lets standardize this, I wouldn't want contrib to start following this - and suddenly using customize when its often not needed.
Comment #8
jhodgdonBojhan: Just to confirm, are you saying that all of these places should be using "Edit"? If so, that is something definite that can be patched.
Comment #10
Bojhan CreditAttribution: Bojhan commentedThere we go removed, a couple notices of it - not sure it didn't take effect on the strings mentioned. Perhaps its coming from the url?
Indeed using edit, though at the dashboard it would probably be Edit dashboard instead of just Edit.
Comment #11
jhodgdonIf you're going to modify this string in dashboard "This dashboard region is empty, click Edit dashboard to add blocks to it.", please remove the comma splice (it is not correct in English to stick two sentences together with a comma - use period or semicolon). Also, I think Edit dashboard in this sentence needs EM or some other HTML markup.
Also, what about all of those email message customize strings on admin/config/people/accounts down at the bottom?
Comment #12
Bojhan CreditAttribution: Bojhan commentedYhea, that should be edited to - I was still somewhat confused why the string on Shortcuts and Dashboard wouldn't actually change
Comment #13
jhodgdon#12: You have to go to the Performance config page and clear the cache to see changes in a hook_menu() change like this.
So are you saying that the email message customize strings should say "edit" rather than "customize" too?
Comment #14
andrewmacpherson CreditAttribution: andrewmacpherson commentedre-roll of the changes in #10.
the comma-splice concern from #11 is fixed.
Comment #15
andrewmacpherson CreditAttribution: andrewmacpherson commentedre-roll of patch in #14
there was a 'Customize' UI string in dashboard.js as well...
Comment #16
aspilicious CreditAttribution: aspilicious commentedI just tried to apply patch, it works and I can't find any customize string (searched for 2 minutes). If this becomes green I'll put this RTBC.
Or is there someone finding more "customize" 's?
Comment #17
jhodgdonThere are problem swith this patch -- not introduced in this patch, but still need to be fixed:
1)
There is text here that cannot be translated. Also we are capitalizing names of pages, and the page is called "Blocks".
So this should be:
(untested but should work).
2)
"Your are now using the new %set_name shortcut set." -- > should be "You are...".
Comment #18
jhodgdonThis patch also doesn't take care of item (c) from the original report:
User email settings all say "Customize the ...". These are on admin/config/people/accounts down at the bottom.
Comment #19
jhodgdonI'll make a new patch...
Comment #20
jhodgdonHere's a new patch, which also fixes the email editing vertical tabs.
Comment #21
Bojhan CreditAttribution: Bojhan commentedIt works
Comment #22
webchickI agree with all of these except Dashboard. "Edit dashboard" sounds very awkward to me. I would expect that to let me change the regions, etc. like in Panels, but it does not. I think what we are doing there is actually customizing, as opposed to the other instances.
What say you?
Comment #23
andrewmacpherson CreditAttribution: andrewmacpherson commentedthe edit dashboard link could keep the word customize, but should be more than one word.
Customize dashboard display
Choose dashboard blocks
Select dashboard blocks
Enable/disable dashboard blocks
Comment #24
Bojhan CreditAttribution: Bojhan commented@webchick I am not sure, I agree that Edit dashboard sounds a bit wierd to the mental model of Panels context. But almost everywhere we use "Edit" to describe editing a certain object - no matter what interaction follows. Perhaps its the location, that makes me sad - rather then the word Customize on its own, but I do not feel that "Customize" on itself is descriptive enough. And Customize dashboard, gets a bit lengthy.
Comment #25
jhodgdonHow about "Configure dashboard"?
I agree with webchick that "edit dashboard" doesn't make sense to me either. "edit" to me has the connotation of changing text, and that's not what you do when you configure the dashboard.
Comment #26
andrewmacpherson CreditAttribution: andrewmacpherson commented+1 for configure dashboard
Comment #27
jhodgdonHere's a patch with "Configure dashboard".
Comment #28
Bojhan CreditAttribution: Bojhan commentedGive the short amount of time, I don't want us to go backwards. Configure causes a completely different mental model, and so does edit. Also configure its mental weight is high, it means configuring heavy things. Lets keep it to customize then, and add "Customize dashboard" to keep it more clear.
Comment #29
jhodgdonI'm on board with Bojhan. One more patch.
Comment #30
lisarex CreditAttribution: lisarex commentedEmail and dashboard changes look good, but I still see on "customize shortcuts"
- in H1 and page title on admin/config/system/shortcut/shortcut-set-1
- in the breadcrumbs on admin/config/system/shortcut/shortcut-set-1/add-link
Comment #31
jhodgdonlisarex: When I cleared my cache, those two places say "Edit" not "Customize".
Comment #32
lisarex CreditAttribution: lisarex commentedverified, woot!
Comment #33
webchickWorks for me!
Committed to HEAD.