Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
currently dblog.admin.inc
contains a bug at line 279, since variable $session
does not exist any more, it should be $_SESSION['dblog_overview_filter']
instead
function dblog_filter_form($form) {
$filters = dblog_filters();
$form['filters'] = array(
'#type' => 'fieldset',
'#title' => t('Filter log messages'),
'#theme' => 'dblog_filters',
'#collapsible' => TRUE,
'#collapsed' => empty($session), // <-- this variable was suppressed
);
Comment | File | Size | Author |
---|---|---|---|
#6 | 674352-6.dblog_session_variable_update.patch | 705 bytes | jersu |
Comments
Comment #1
arhak CreditAttribution: arhak commentedNote that this bug goes away if #582622: provide hook for dblog_filters gets in first, since it uses another approach for determining whether the fieldset should be collapsed/expanded (taking into account every available filter)
Comment #2
arhak CreditAttribution: arhak commentedComment #3
mr.baileysCan you roll a patch for review/testing?
Comment #4
mr.baileysMarked #721282: show Filter log messages if it selected as a duplicate.
Comment #5
arhak CreditAttribution: arhak commentedI have no CVS copy of Drupal
from the time I download the dev tarball to the time it gets reviewed... around three months pass in between..
nevertheless, I would do it if you insist
Comment #6
jersu CreditAttribution: jersu commentedHere's the patch that removes the unknown variable $session and replaces with $_SESSION['dblog_overview_filter'].
Comment #8
Scott Falconer CreditAttribution: Scott Falconer commented#6: 674352-6.dblog_session_variable_update.patch queued for re-testing.
Tested locally against current head and this passed. Not sure why filter.test failed, but there was an hour+ delay in testing after submit...so something might have gotten out of date during the wait.
Comment #9
Jody LynnLooks good.
Comment #10
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.