this is how to reproduce the problem
create quick tab
insert two tabs
tab1_en and tab2_en (in that order)
search for the string and translate them
lets say
tab1_en -> tab1_translated
tab2_en -> tab2_translated
now go and rearrange the order of the tabs so that second tab goes to first position
then viewing the quicktabs on the second language the tabs appear to still have the old order
tab1_translated
tab2_translated
meanwhile the content has the correct order but the tab labels are wrong
tab1_translated contains the translated content of tab2_en
tab2_translated contains the translated content of tab1_en
Comment | File | Size | Author |
---|---|---|---|
#9 | quicktabs-fix_translations_mix_when_rearranging_order-673952.patch | 1.07 KB | mihalache |
|
Comments
Comment #1
Pasqualletagging
Comment #2
katbailey CreditAttribution: katbailey commentedRemoving the Release blocker tag. If nobody else is having this problem then I don't see it as bad enough to block a release. If someone wants to provide a patch, then great - otherwise I don't have the time to set up a multilanguage environment just for the sake of testing this.
Postponing until somebody confirms that it is still a bug, and moving to the 3.x branch.
Comment #3
PasqualleAs tabs are identified by number (weight) which is used for translation this is still a problem. The solution would be to use unique string identifiers for tabs, similarly as views module identifies displays..
I agree this is not a release blocker, but still a bug.
Comment #4
pfrenssenMarked #2002840: Tab title translation doesn't adjust when moving tabs. and #1655880: Translation of quicktabs got Mixed up with other qucktabe sets. as duplicates of this issue. This is also occurring on 7.x-3.x. Unpostponing this because as far as I can tell there is nothing blocking this issue.
Comment #5
pfrenssenWould it be an idea to replace the sequential numeric IDs with UUIDs?
Comment #6
pfrenssenRaising this to major. This makes the module unusable in multilingual environments.
Comment #7
knalstaaf CreditAttribution: knalstaaf commentedAgreeing with pfrenssen: this is at least a major bug. Critical even for international websites or sites in countries where more than one language is spoken (more than half of the world population speaks two languages, which indicates one can't just look away from it, with all due respect). It renders the module redundant for multilingual websites, which is seldom compared to other modules nowadays. What makes it even more alarming is that adding new tabs (in the correct order) to replace the old ones does not solve the problem - there's no solution (that I know of) at all currently (this point makes the issue critical imo).
If I had the technical background I'd willingly try to sort out the issue. Setting up a multilingual site just for testing is no big deal, takes 15 minutes. Use this drush line and add a language of choice (no extra configurations needed):
drush en i18n i18n_block i18n_field i18n_menu i18n_node i18n_path i18n_string i18n_redirect i18n_translation i18n_variable i18nviews -y
and you're done ;)Would there be a manual approach (in code) to solve this issue for the time being please?
Comment #8
knalstaaf CreditAttribution: knalstaaf commentedDeleting the whole Quickset and start over is a possible solution (gave it another name as well to make sure). As being no solution out there was my motivation to mark this as critical, I'm returning this to major.
Willing to help if I can…
P.S.: Somewhat related: if there's a tab that doesn't seem to be translatable, add another one with the same name, and translate it with the translation UI. You can remove that extra tab afterward.
Comment #9
mihalache CreditAttribution: mihalache as a volunteer commentedMore than 10 years since the issue was reported. I know that the solution is not perfect but it does the job. I am aware of the downsides but at least reordering the tabs works now.
The downsides of this patch seems to be when the string is changed in the base language aka renaming the tab:
t()
function, so from a content editor point of view it's an expected behavior.i18n_string
table with contextsComment #10
mihalache CreditAttribution: mihalache commented.
Comment #11
apadernoComment #13
shelaneI’m not sure when I’ll be doing another 7 release, but at least getting this committed will help users who want to be on the dev release.