When running under php 5.3.0, the uc_products view does not display the product image. If I dump the same database and files onto php 5.2.x then it displays the image just fine.

Comments

TR’s picture

TR CreditAttribution: TR commented
Issue tags: +PHP 5.3

Tagging. Would it be possible for you to track this down and create a patch? I'm not running PHP 5.3 here.

bkat’s picture

bkat CreditAttribution: bkat commented

The view seems to be working now but I don't seem to have modified any ubercart files. I have fixed many other bugs related to php 5.3 and they are almost all related to callback functions having parameters declared as references. I know that I fixed some things in the image API so if the uc_product view uses that, it would have been fixed implicitly.

Feel free to close this one.

TR’s picture

TR CreditAttribution: TR commented
Status: Active » Closed (fixed)

I have fixed many other bugs related to php 5.3 and they are almost all related to callback functions having parameters declared as references

If you find PHP 5.3 problems that needs to be fixed in Ubercart, please let us know. Many of these cases have already been fixed, but I'm sure there are some still out there. Just be aware that removing the & may make the error go away but can also cause problems, as we have seen with some previous issues which tried to do just that. A patch to fix any problems you find would be greatly appreciated.