Active items in top level IA don't have the light gray background when overlay is enabled

Looks like this only occurs when the overlay is showing - disabling the overlay module makes it work again for me.

Ok fix:
- toolbar.js seemed to already handle this, but it should be handled in overlay (which overrides link behavior) as also other modules (e.g. admin_menu) could use overlay-displace-top.
- Added code to overlay-parent.js that matches all links in displaced regions (like toolbar) against overlay.location/window.location on respectively opening/closing of the overlay and toggles class active.

Wrong patch

replaced windowPath by overlayPath, which is what it is about.

Duh of course! I forgot about that.

This fix conflicts with patch in #668104: Make overlay respect other click handlers. That one should be reviewed/committed first.

Ok #668104: Make overlay respect other click handlers landed. This issue is almost fixed now:

It isn't working when clean URLs are disabled.

Doesn't seem to be related, that should be solved in #685790: No Overlay when Clean URLs are off

Oops, needs review still. Can anyone else confirm its working?

Its already working when enabled. We only need to fix this for the situation when clean URLs is disabled. There's no patch for that yet.

This patch makes it also work when clean URLs is disabled.

Ok, looks good.

Dries looked at this, but it doesn't work, also its not an overlay only bug.

styling wasn't applied to li.active-trail a but only to li a.active

attached patch adds the selector for the active trail

I don't think another #toolbar div.toolbar-menu ul li.active-trail a:hover { ... } is needed, so I didn't add that

upsydoodle

In Firefox, at least, I am not seeing any problem whatsoever except when the overlay is enabled. Please post details and steps to reproduce if there is some specific problem when the overlay is turned off.

Also, the patch in #15 was committed (http://drupal.org/cvs?commit=325074) but the problem does persist, at least partially:

1. When clean URLs are disabled, it doesn't seem to work at all.
2. When clear URLs are enabled, it works, but I'm occasionally seeing a "flash" of the background - that is, if I click on "Modules" (for example), the background of that link will turn light gray, then turn black again while the iframe is loading, then turn light gray again after the page load is complete. This doesn't happen always, maybe 25-50% of the time though.

moved #20 to #707070: Top level IA items don't keep their active styling when they are in the active trail but not the active item

#20: toolbar-active-trail-styling.patch queued for re-testing.

So what's left?

Patch makes it work when clean URLs is disabled.

Patch also will set active class on links that are in the active trail. E.g. admin/user when visiting admin/user/permission.

1) I tested the patch with and without clean urls (in several browser: IE, chrome, firefox).
It does what it is saying it does
==> OK

2) With this patch we have the same behaviour inside and outside the overlay (when it comes down to active links)
==> OK

3) The code for the links that are in the active trail looks sane

-    if (linkDomain == windowDomain && linkPath == activePath) {
+    if (linkDomain == windowDomain && activePath.indexOf(linkPath) === 0) {

==> OK

Marking this rtbc

Committed to CVS HEAD.

Previous patch had a minor regression: the home link was always considered being in the active trail and thus received the active class.

The frontpage will never be loaded inside the overlay so a simple check for an empty path is sufficient.

My fault.
Hmm Looks good but I'll let someone else rtbc this one ;)

It needs a comment.

- Added comment
- Added trailing slash to test to prevent wrong matches like "admin/content/node" matching "admin/content/node-types".

Anyone?

Well, i'll rtbc this again.

Still applies.

Still some problems with shortcuts. With following links.

#overlay=node/add/article
and
#overlay=node/add

If you are in add/article, add is highlighted too

Home icon issue is fixed

Since #20 we also try to set trail links to active. In overlay we just check whether the link is a parent of the active link. Drupal however uses the menu system; parent links aren't always active trail links.

To get this same functionality in overlay will be hard. Lets just commit this patch first.

RTBC for the patch just tof ix the anoying home menu issue.
But afterwards put this back to needs work, drupal behvaiour and overlay behaviour should match as good as possible.

If we can access the result of a php function we can (if there isn't any yet) make a function that checks if a link is a parent of an other link.

To be perfectly honest, I don't think we should be highlighting the active trail in toolbar - I'd rather just see my current location. But I'll leave that up to the UX folks. I'm rerolling the patch in #32, which fixes the immediate Home link issue, and I agree is RTBC.

Chasing HEAD (my local copy was out of date).

active class on Home link should be reset if the overlay closes and the parent location is home.

Committed to CVS HEAD. Thanks.