Provide way to disable rebuild during features_flush_caches()

Out of curiosity are the rebuilds in question getting logged to watchdog? The rebuild process was rewritten in beta4, so it should only actually run rebuild scripts (e.g. the CCK ones) when there are actual changes to push out. If no component changes are present no actual rebuilding (and subsequently cache clearing) should occur.

If they are occurring and there aren't changes we've got a bug on our hands.

Marked #658772: Provide way to disable rebuild during features_flush_caches() as duplicate.

Here's a 6.x that need to port to 7.x but don't have time atm.

It adds a variable to disable features_flush_cache

(There's various reasons to want that, for example if need to run updates before it does it.)

ported to 7.x

added trailing spaces (ported to 7.x)

I think this patch is very interesting, but it needs to be re-rolled against the latest 1.x-dev and be sure to create your patch from the Features module directory itself and not from your Drupal home directory.

I think the hook needs to be removed completely. See #1572578: Rethink the way features are enabled / disabled for an alternative approach proposal.

Had to rewrite the patch to work with drupal standard.

Updated for 7.x-2.0-beta2, so it's slightly different.

Also, reworded the description on the settings page slightly so its in clearer English.

I've marked #1917288: Don't trigger features rebuild on cache clear as a duplicate of this issue.

It's angel was that opening the admin/modules pages calls features_var_export() > 100.000 times on a large site.
The patch from #10 unfortunately does not 'fix' that.

It has some cachegrind info which could be usefull here ...

No, it won't fix that issue, so they may not be dupe's.

The patch works for me, but is the rebuild ever necessary?

When I do a drush cc all, Features tries to update a field definition - and fails with a FieldUpdateForbiddenException in some cases.

If I read http://drupal.org/node/582680 correctly, this should not happen. I'm not trying to revert the feature, I'm trying to clear the cache.

Reroll of #10 against 7.x-2.0-dev

+++ b/features.module
@@ -173,6 +173,17 @@ function features_menu() {
+  $items['admin/structure/features/settings'] = array(
+    'title' => 'Settings',
+    'description' => 'Set advanced settings for features module.',
+    'page callback' => 'drupal_get_form',
+    'page arguments' => array('features_settings_form'),
+    'access callback' => 'user_access',
+    'access arguments' => array('administer features'),
+    'type' => MENU_LOCAL_TASK,
+    'file' => 'features.admin.inc',
+    'weight' => 15,

This isn't needed anymore since the tab exists now

commited to 7.x-2.x

#3: 658772_features_rebuild_on_flush.patch queued for re-testing.

Thank you for committing this!!

As has been mentioned before on this ticket (and its duplicates), rebuilding also occurs when hitting the /admin/modules page (and that's not from a cache clear, it's done explicitly in a form_alter hook) -- I believe this setting ought to be extended/replicated to disable that too, so I've opened #2036935: Provide way to disable rebuilding features on admin/modules page.

Patch for 6.x-1.x, also going to create one for #1153028: menu_links_features_export_options() dies with too many items.

Here's a patch to apply if you apply the one from #1153028: menu_links_features_export_options() dies with too many items. first

If you need the hook removed in 7.x-1.x, you could use hook_module_implements_alter() to remove the hook implementation. :)

Most likely backport to 6.x won't happen, therefore marking as fixed.