API lists the arguments passed to 'settings callback' variously as "form_state, filter, defaults, format, filters" or "form, form_state, filter, defaults".

The correct argument order, as seen in filter.module's own code, is "form, form_state, filter, format, defaults". (Try to say that fast. ;) )

As this is a hook documentation, the patch will not need to be committed by a maintainer.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cburschka’s picture

Status: Active » Needs review
FileSize
1.44 KB

Eh, my info is out of date - D7's hooks are tucked safely into core in $module.api.php files.

So here is a core patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

cburschka’s picture

Status: Needs work » Needs review

This patch changes only a comment section. :(

Arancaytar requested that failed test be re-tested.

Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.