Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Arianek and I decided to split up #632716: Help File Fixup: field*, file, filter, locale, translation, trigger into separate issues/patches. Please review the relevant section of the last patch for this can be found at http://drupal.org/node/632716#comment-2285200
Post review / screenshots and rerolled patches here -- thanks!
Comment | File | Size | Author |
---|---|---|---|
#18 | filterfix-2.patch | 3.03 KB | David_Rothstein |
#14 | filterfix-2.patch | 3.03 KB | David_Rothstein |
#13 | filterfix.patch | 3.03 KB | jhodgdon |
#9 | 645784fixup.patch | 2.42 KB | jhodgdon |
#6 | help_filter5.patch | 6.42 KB | arianek |
Comments
Comment #1
arianek CreditAttribution: arianek commentedmanually cut this from the mondopatch
Comment #2
tobiasbComment #3
lisarex CreditAttribution: lisarex commentedThis patch hasn't been reviewed properly yet.
- put caps on module names and linked pages
- moved link to handbook as has been done in the other fixed d7help patches
- removed 'for instance'
- remove post in 'Filters and text formats' section
- bit of rephrasing final sentence of 'Filters and text formats' section
- reordered the text formats to default display order
Comment #4
arianek CreditAttribution: arianek commentedjust made a couple little format and grammar tweaks. seems decent.
Comment #5
webchickUnfortunately, this no longer applies. :( I can haz a quick re-roll?
Incidentally, CONGRATULATIONS on making this module actually intelligible by mere mortals! Awesome.
Comment #6
arianek CreditAttribution: arianek commentedyessssssssssssss :-)
Comment #7
webchickAwesome! Committed to HEAD.
Comment #8
David_Rothstein CreditAttribution: David_Rothstein commentedI assume this part was due to an unintentional copy-paste and should be rolled back?
See #504076: Improve Text Format Admin Description
Comment #9
jhodgdonYes, it does look like this was an unintentional reversal of the work that was done in #504076: Improve Text Format Admin Description.
Here's a patch to set it right.
Setting it to RTBC since I took the two lines added directly from the final patch in #504076: Improve Text Format Admin Description.
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedThanks. I confirm that this is RTBC, assuming the testbot agrees :)
Comment #11
webchickOops! Thanks. Committed to HEAD.
Comment #12
jhodgdonI'm reopening this issue, as the Filter module help has a couple of issues. Two minor/typo/style issues:
- "adds, removes or transforms" - needs comma before "or" as per our doc standards.
- "URLS" should be "URLs".
The other issue is a factual error. It says:
I used the "expert" install profile, and I didn't have all 3 default formats mentioned in the help screen, but only "plain text". So we should probably note that the 3 default formats only come with the default install profile, or just take out the mention of the specific defaults, or say something like "Depending on your install profile, you will have one or more default text formats defined.".
Comment #13
jhodgdonHere's a patch that fixes the two typos, and changes the wording of the section in question to:
Comment #14
David_Rothstein CreditAttribution: David_Rothstein commentedI changed "drupal" to "Drupal" and "install profile" to "installation profile" but otherwise looks good to me...
Comment #17
jhodgdonAssuming the test bot approves the latest patch (which I think it should), I would set it to RTBC.
Comment #18
David_Rothstein CreditAttribution: David_Rothstein commentedHm, not sure what happened there, so I'm just going to reupload it.
Comment #19
arianek CreditAttribution: arianek commentedlooks gooda, new patch applied fine
Comment #20
webchickCommitted to HEAD. Thanks!