Arianek and I decided to split up #632716: Help File Fixup: field*, file, filter, locale, translation, trigger into separate issues/patches. Please review the relevant section of the last patch for this can be found at http://drupal.org/node/632716#comment-2285200

Post review / screenshots and rerolled patches here -- thanks!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arianek’s picture

Status: Active » Needs review
FileSize
7.09 KB

manually cut this from the mondopatch

tobiasb’s picture

Status: Needs review » Reviewed & tested by the community
lisarex’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
81.76 KB
6.01 KB

This patch hasn't been reviewed properly yet.

- put caps on module names and linked pages
- moved link to handbook as has been done in the other fixed d7help patches
- removed 'for instance'
- remove post in 'Filters and text formats' section
- bit of rephrasing final sentence of 'Filters and text formats' section
- reordered the text formats to default display order

arianek’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
6.35 KB

just made a couple little format and grammar tweaks. seems decent.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Unfortunately, this no longer applies. :( I can haz a quick re-roll?

Incidentally, CONGRATULATIONS on making this module actually intelligible by mere mortals! Awesome.

arianek’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
6.42 KB

yessssssssssssss :-)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome! Committed to HEAD.

David_Rothstein’s picture

Status: Fixed » Needs work

I assume this part was due to an unintentional copy-paste and should be rolled back?

-      $output = '<p>' . t("Control which HTML tags and other formatting can be used for text input. Don't allow too much formatting for untrusted users. This can be a serious security risk.") . '</p>';
-      $output .= '<p>' . t('Text formats are presented in the order you arrange them below. Configure a text format to change its behavior.') . '</p>';
+      $output = '<p>' . t('Use the list below to review the text formats available to each user role and to control the order of formats listed in the <em>Text format</em> fieldset. (The <em>Text format</em> fieldset is displayed below textareas when users with access to more than one text format create multi-line content.) All text formats are available to users in roles with the "administer filters" permission, and the special %fallback format is available to all users. You can configure access to other text formats on the <a href="@url">Permissions page</a>.', array('%fallback' => filter_fallback_format_title(), '@url' => url('admin/config/people/permissions', array('fragment' => 'module-filter')))) . '</p>';
+      $output .= '<p>' . t('Since text formats, if available, are presented in the same order as the list below, and the default format for each user is the first one on the list for which that user has access, it may be helpful to arrange the formats in descending order of your preference for their use. Remember that your changes will not be saved until you click the <em>Save changes</em> button at the bottom of the page.') . '</p>';

See #504076: Improve Text Format Admin Description

jhodgdon’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
2.42 KB

Yes, it does look like this was an unintentional reversal of the work that was done in #504076: Improve Text Format Admin Description.
Here's a patch to set it right.

Setting it to RTBC since I took the two lines added directly from the final patch in #504076: Improve Text Format Admin Description.

David_Rothstein’s picture

Thanks. I confirm that this is RTBC, assuming the testbot agrees :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Oops! Thanks. Committed to HEAD.

jhodgdon’s picture

Status: Fixed » Needs work

I'm reopening this issue, as the Filter module help has a couple of issues. Two minor/typo/style issues:
- "adds, removes or transforms" - needs comma before "or" as per our doc standards.
- "URLS" should be "URLs".

The other issue is a factual error. It says:

There are three formats included by default; Filtered HTML (which allows only an administrator-approved subset of HTML tags), Full HTML (which allows the full set of HTML tags), and Plain text (which removes all HTML tags). Additional formats may be created by an administrator on the Text formats page.

I used the "expert" install profile, and I didn't have all 3 default formats mentioned in the help screen, but only "plain text". So we should probably note that the 3 default formats only come with the default install profile, or just take out the mention of the specific defaults, or say something like "Depending on your install profile, you will have one or more default text formats defined.".

jhodgdon’s picture

Status: Needs work » Needs review
FileSize
3.03 KB

Here's a patch that fixes the two typos, and changes the wording of the section in question to:

One format is included by default: Plain text (which removes all HTML tags). Additional formats may be created by your install profile when you install drupal, and more can be created by an administrator on the Text formats page.

David_Rothstein’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
3.03 KB

I changed "drupal" to "Drupal" and "install profile" to "installation profile" but otherwise looks good to me...

Status: Reviewed & tested by the community » Needs work
Issue tags: -d7help

The last submitted patch failed testing.

Status: Needs work » Needs review
Issue tags: +d7help

David_Rothstein requested that failed test be re-tested.

jhodgdon’s picture

Assuming the test bot approves the latest patch (which I think it should), I would set it to RTBC.

David_Rothstein’s picture

FileSize
3.03 KB

Hm, not sure what happened there, so I'm just going to reupload it.

arianek’s picture

Status: Needs review » Reviewed & tested by the community

looks gooda, new patch applied fine

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -d7help

Automatically closed -- issue fixed for 2 weeks with no activity.