uc_ups.admin.inc holds functions (such as module settings forms) that are intended to be used only be the administrator. They are separated into this include file so that they are loaded into memory only when needed.

However, theme_uc_ups_option_label() is also located in uc_ups.admin.inc. This theme function is used every time a UPS shipping quote is obtained. Thus, uc_ups.admin.inc is being loaded unnecessarily for every customer, defeating the purpose of separating admin functions from the rest of the module, and increasing the memory footprint needed for the customer.

The solution is to put theme_uc_ups_option_label() back into uc_ups.module. Patch attached.

CommentFileSizeAuthor
uc_ups.module.theme_.patch900 bytesTR
uc_ups.admin_.inc_.patch698 bytesTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR’s picture

Status: Active » Needs review
Island Usurper’s picture

Status: Needs review » Fixed

Thanks, TR. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.