uc_ups.admin.inc holds functions (such as module settings forms) that are intended to be used only be the administrator. They are separated into this include file so that they are loaded into memory only when needed.
However, theme_uc_ups_option_label() is also located in uc_ups.admin.inc. This theme function is used every time a UPS shipping quote is obtained. Thus, uc_ups.admin.inc is being loaded unnecessarily for every customer, defeating the purpose of separating admin functions from the rest of the module, and increasing the memory footprint needed for the customer.
The solution is to put theme_uc_ups_option_label() back into uc_ups.module. Patch attached.
Comment | File | Size | Author |
---|---|---|---|
uc_ups.module.theme_.patch | 900 bytes | TR | |
uc_ups.admin_.inc_.patch | 698 bytes | TR | |
Comments
Comment #1
TR CreditAttribution: TR commentedComment #2
Island Usurper CreditAttribution: Island Usurper commentedThanks, TR. Committed.