1) Add a field in "Article" content type called field_test.
2) In admin/config/people/accounts/fields that field doesn't appear (although if you try to manually add it, an error is given).

CommentFileSizeAuthor
#10 626664-field_ui_add_existing_field-10.patch3.75 KByched
#8 626664-field_ui_add_existing_field-7.patch3.3 KByched
#6 626664-field_ui_add_existing_field-7.patch3.3 KByched
#4 626664-field_ui_add_existing_field-5.patch3.31 KByched
#3 626664-field_ui_add_existing_field-3.patch2.97 KBamitaibu
#2 field_ui_add_existing_field.patch2.2 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

I see in the code that $existing_field_options = field_ui_existing_field_options($obj_type, $bundle); so maybe this is by design? I think it shouldn't take the obj_type in account, and show *all* existing fields.

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
field_ui_add_existing_field.patch2.2 KB

field_ui_existing_field_options() rightfully receives $obj_type, it's rather that internally it should examine all field instances, not just field instances for the current entity type.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
626664-field_ui_add_existing_field-3.patch2.97 KB

Added a test to yched's patch. I get a PDOException error on any tests on my local, so I'm not sure if the test pass.

yched’s picture

yched CreditAttribution: yched commented
FileSize
626664-field_ui_add_existing_field-5.patch3.31 KB

You're right, this deserves a test, thanks for this.

Attached patch moves the test at then end of the 'add new field' workflow test, removes a double parenthesis error, and uses a more accurate assert.

Test failures : yes, core is currently broken : #626866: Test bot broken - and #623992: Reduce {system} database hits

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

minor: 

+    // different entity types; .g. if a field was added in a node entity, it

should be e.g.

yched’s picture

yched CreditAttribution: yched commented
FileSize
626664-field_ui_add_existing_field-7.patch3.3 KB

Oopsie :-)

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
626664-field_ui_add_existing_field-7.patch3.3 KB

Re test please.

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
626664-field_ui_add_existing_field-10.patch3.75 KB

Doh, wrong boolean logic...

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Needs review » Reviewed & tested by the community

Tests pass, and functionality is fixed as-well.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.