A module that wants to provide a different behavior and representation for contextual links will have a performance impact, because the JS/CSS cannot be altered once.

Just make it a library and the issue is resolved.

I already had this in mind when doing the original implementation, but somehow, I forgot.

CommentFileSizeAuthor
drupal.contextual-links-library.patch1.2 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

Simple and elegant. Like sun said, having this allows contrib modules to change how the contextual links look/work.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

I want this to get in before doing #626286: Make contextual links a module

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

How can you forget? Jeez :'D

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Makes sense to me.

Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Contextual links

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Contextual links

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.