Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After attaching an image to a Story, while displaying a listing created with Views2 I got this message. Workaround attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 620234.image_attach.handler-output.patch | 1.77 KB | joachim |
| image_attach_views_handler_field_attached_images.patch | 524 bytes | unjello | |
Comments
Comment #1
joachim CreditAttribution: joachim commentedIs that with E_ALL?
Grr why can't PHP by a bit more laid back about these things? :(
Thanks for taking the time to roll a patch.
However, since $output is only set once (just in 3 different places depending on your flow), I prefer a visually cleaner fix -- actually set it rather than append to it. (I just tend to append when coding to avoid data clobbering bugs if I rearrange stuff...)
Could you test the attached please and confirm it also fixes your bug?
I can then commit it :)
Comment #2
unjello CreditAttribution: unjello commenteday, that does the trick too... and i agree it looks better. i just went for whatever removed the warning in fastest way :]
Comment #3
joachim CreditAttribution: joachim commentedCommitted to CVS.
Thanks for reporting and making a patch!