Overlay: Fix redirects [#619352]

From http://drupal.org/node/610234#comment-2202806 :

4. The overlay does not work correctly with contextual links and in particular the drupal_get_destination() part of it. From the "main site", clicking on a contextual link (e.g., 'configure block'), doing your thing in the overlay, and then hitting the submit button does not take you back to where you were directly, but rather loads a copy of where you were inside the overlay.

I was originally thinking maybe we could just wipe out destination strings altogether on these links, since destination and the overlay are trying to solve the same problem, but I talked to yoroy in IRC and his instinct was that we should respect the destination.

Comments

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 7 December 2009 at 06:01

Status:

Active

» Fixed

This problem no longer seems to occur. There are other problems with the overlay/contextual links combo, but those will be separate issues when I get around to filing them :)

Comment #2

joetsuihk CreditAttribution: joetsuihk commented 18 December 2009 at 01:51

Priority:	Normal	» Critical
Status:	Fixed	» Active

Sill happens to me: The overlay does not work correctly with contextual links and in particular the drupal_get_destination() part of it

reproduce:
1. go to home page
2. click on "people" in admin_menu, opens overlay
3. click "edit" on a user in overlay, which open url like "user/1/edit?destination=admin/people%3Frender%3Doverlay"
4. edit the user info (i did a pic upload)
5. press save
6. being redirected to "admin/people?render=overlay"

i think this is an issue with drupal_get_destination(), in user.module line 185 to 204

critical. D7 cannot ship with this obvious bug in overlay

Comment #3

joetsuihk CreditAttribution: joetsuihk commented 18 December 2009 at 01:59

edit: node admin form works.

should be a problem with user.admin.inc line 204, compared to node.admin.inc line 505

a quick search on issues, seems not a report yet. i should open a new one and close this?

Comment #4

joetsuihk CreditAttribution: joetsuihk commented 18 December 2009 at 02:49

ok, sorry for spam-ing, line 204 in user.admin.inc do not have a problem.

the problem may goes to overlay.module, that the edit link do not open in overlay, step 3 above...

Comment #5

David_Rothstein CreditAttribution: David_Rothstein commented 18 December 2009 at 04:26

Priority:

Critical

» Normal

Yeah, I think you are probably right that it makes sense to show user edit forms and the like in the overlay, seeing as how node edit forms are shown there now....

Since that's kind of a separate issue, can you post a new issue for it and post the link here when you do (then mark this issue "fixed" again)? Thanks!