Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Gave the patch a once-over; looked good. Unsure if it's wise to clean-up LICENSE.txt though.
-K
Comment | File | Size | Author |
---|---|---|---|
#4 | doublespace.patch_0.txt | 131.92 KB | Zen |
doublespace.patch.txt | 147.01 KB | Zen |
Comments
Comment #1
drummWhile it is good to have single spacing, this would cause the translations of all these strings to be lost. It will be best to remove these as the various strings are changed for other reasons. Slow, but translatable.
Talk to killes about this issue if you want to think of ways to move ahead, he maintains locale.
Comment #2
Zen CreditAttribution: Zen commentedThis early in the cycle?
Looking at it from another perspective, there are ~140 t()s in this patch. If one assumes that about 50% of these will be modified by the time 4.8 is out, this patch will introduce minor whitespace work on 70 t()s.. And if one takes into account the plans to nix a third of the modules in core, this number becomes lower and lower.
Stats:
Total lines in patch: 1791
Total fixes: ~870
t()s fixed: ~140
Others [comments + text files]: ~730
License.txt lines fixed: ~130
Comments fixed: ~600
IMO, it's best to do this now, rather than progressively or later.
My 10p.
Thanks,
Karthik.
Comment #3
killes@www.drop.org CreditAttribution: killes@www.drop.org commented1) double spaces won't be shown in HTML, so it is kind of pointless to fix them. :P
2) Many of the patched places are in documentation strings, which don't get translated.
3) Don't change the license file, we want it to be 1:1 with the official GPL version, I think.
4) breakign translations isn't nice, but will occur anyway and this is a patch for head. Translations won't be completely lost, but probably will only be marked as "fuzzy".
Comment #4
Zen CreditAttribution: Zen commentedSame patch minus LICENSE.txt
-K
Comment #5
drummComitted to HEAD.
All the chunks applied cleanly except for a few offset lines, so I think this is done, but you might want to double-check.
Comment #6
(not verified) CreditAttribution: commented