Document why we call drupal_get_filename() in module_list() [#615734]

Was looking through module_list() for optimizations, and while in there found a no-op call to drupal_get_filename(), except it's not a no-op call, it actually primes drupal_get_filenames() static cache to avoid it being looked up in subsequent calls to drupal_load(). This has been there since 2005 or earlier, patch just adds some documentation as to why we're doing it.

Comment	File	Size	Author
#6	filename.patch	961 bytes	catch
#6
#1	filename.patch	754 bytes	catch
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

catch

he/him

English

CreditAttribution: catch commented 27 October 2009 at 11:08

File	Size
filename.patch	754 bytes

patch.

Comment #2

moshe weitzman CreditAttribution: moshe weitzman commented 28 October 2009 at 00:47

Whats the benefit of priming the cache? Why not let it get primed by the first caller?

Comment #3

catch

he/him

English

CreditAttribution: catch commented 28 October 2009 at 01:33

drupal_get_filename() does a database hit for every file it looks up unless it's already in the cache - at least that's the behaviour when called from drupal_load() - we're passing the explicit filename we got from the {system} query - so that way it gets the filenames in static instead of having to do it's own lookup.