D7: .to-overlay is not used anymore as a trigger to open the overlay but is kept in toolbar module still; our patch should remove that obsolete code

CommentFileSizeAuthor
#4 toolbaroverlay.patch1.67 KBcasey
#2 toolbaroverlay.patch1.5 KBcasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Title: Overlay D7: remove cruft from toolbar module » Remove overlay-related cruft from toolbar module
Component: other » toolbar.module

Retitling.

casey’s picture

casey CreditAttribution: casey commented
Status: Active » Needs review
FileSize
toolbaroverlay.patch1.5 KB
marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented
Status: Needs review » Needs work

The patch makes total sense, but after applying the toolbar links are left with an empty class attribute, for instance:

<a title="Select and configure your themes" id="toolbar-link-admin-appearance" href="http://localhost/d7/node#overlay=admin/appearance" class=""><span class="icon"></span>Appearance <span class="element-invisible">(Select and configure your themes)</span></a>

I couldn't really figure out where it comes from, can it be removed?

casey’s picture

casey CreditAttribution: casey commented
Status: Needs work » Needs review
FileSize
toolbaroverlay.patch1.67 KB

Reroll.

Issue that @marcvangend mentioned seems to be fixed already.

casey’s picture

casey CreditAttribution: casey commented

Anyone?

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Yes, me! Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -overlay

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +overlay

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.