Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Pending design direction from #614410: Patterns for recent-items-blocks on the dashboard we'll probably want to change this block a bit. Creating the issue now so that we may have workflow and seperate implementation issues from design discussions. Thanks.
Comment | File | Size | Author |
---|---|---|---|
#12 | commentrecent.patch | 4.02 KB | casey |
Comments
Comment #1
yoroy CreditAttribution: yoroy commentedComment #2
yoroy CreditAttribution: yoroy commentedReplace 'content' with comments:
design process leading towards this proposal is in #614410: Patterns for recent-items-blocks on the dashboard
Comment #3
yoroy CreditAttribution: yoroy commented#337947: Correct whitespace issue for 'recent content block' in dashboard is as good as done. We'd like to see the implementation over there used here for comments as well.
First decision to make:
Make this a new dashboard specific 'recent comments' block, or rework the already existing 'recent comments' one?
Comment #4
bleen CreditAttribution: bleen commented+1 for "rework the already existing 'recent comments' one"
Comment #5
Bojhan CreditAttribution: Bojhan commentedSo I assume that its actually better to reuse the code of recent content block, because that has gone trough much more rigorous review process then the recent comments block. As we learned we usually require quite some refactoring.
Comment #6
yoroy CreditAttribution: yoroy commentedYes of course. My question was if we want to have 2 seperate 'recent comments' blocks, 1 for front-end use, and another one for dashboard use. Maybe they can also be the same block and let permissions determine which links are shown etc.
Comment #7
David_Rothstein CreditAttribution: David_Rothstein commentedI think in general the rule should be to make them separate blocks. See comments by @catch and I on the original Dashboard issues, for example, starting around:
http://drupal.org/node/544360#comment-2124036
http://drupal.org/node/569190#comment-2124026
In this case, though, if it's really the exact same block just with edit/delete links added based on permissions, then it could make sense to use the same one. However, if there's only one block, it means that sites which do not have a separate admin theme have to choose where they want it (either on the dashboard, or on the main site, but not both).
Comment #8
yoroy CreditAttribution: yoroy commentedYes, that's why I asked :)
Comment #9
casey CreditAttribution: casey commentedSubscribing... I hope to work on this tomorrow.
Comment #11
casey CreditAttribution: casey commented@yoroy So do we need two seperate blocks?
initial patch (needs tests).
Comment #12
casey CreditAttribution: casey commentedForgot patch
Comment #13
webchickHm. I don't like this idea, I don't think. Existing D6 sites are using that block and are going to expect it to work the same, not all of a sudden become a huge table with edit/delete links that breaks the sidebar in their theme.
Since this is intended to be used in a different context than the former recent comments block, it should be its own thing, preferably with "Dashboard" somewhere in the name to differentiate it from the other.
Comment #14
yoroy CreditAttribution: yoroy commentedOk, new block from scratch it shall be.
Comment #15
casey CreditAttribution: casey commentedWhere do we define that block? comment.module or dashboard.module? And what title should it have?
Comment #16
webchickI would say comment.module. Dashboard is intended to be merely a framework for displaying these blocks. Also, contributed modules won't have the opportunity to add their own blocks to dashboard module, so core modules shouldn't cheat. :)
On the title, I defer to the UX team. It's a little tricky. We want this and the new Recent Content block to be clear that they form a "pair". We also do not want this block and the old "Recent comments" to be confused.
Comment #17
webchickFixing #601932: Allow dashboard to limit available blocks would allow us to exclude the original recent comments block. I'm not sure though. If you wanted to put some big huge graphs in the center, it might actually make sense to use the "minimal" recent comments block in the smaller area to the side.
Comment #18
yoroy CreditAttribution: yoroy commentedThe title can only be 'Recent comments for dashboard' then. Anything else would be lying :)
Comment #19
Bojhan CreditAttribution: Bojhan commentedCan we get some activity on this?
Comment #21
sun.core CreditAttribution: sun.core commentedNot critical. Please read and understand Priority levels of Issues, thanks.
Comment #22
andypostRecent content block already looks ugly for anonymous users within new default theme. Blank cells are useless and eats a page area
Comment #23
amc CreditAttribution: amc commentedPossibly related with regard to style issues: #849670: Recent content block usability
Comment #24
andypostAlso proposed markup for theming "time ago" #807744: Use microformat for theme_comment_block()
Comment #26
andypostMaybe better to add check for dashboard in theme_comment_block() like #849670-8: Recent content block usability
Comment #29
stevestanco CreditAttribution: stevestanco commentedThis new block for recent comments help me in reduction of spam on my blog.
Comment #31
yoroy CreditAttribution: yoroy commentedComment #32
star-szrDashboard module is no longer in core, see #950956: Remove Dashboard from core . Moving to 7.x for consideration.
Comment #33
andypostAt least the implementation should be cleaned-up, having dumb theme function makes no sense.
So needs to check:
- need in current custom theme function - move to current build method - #2054993: Remove (untested, unused, broken) comment_get_recent()
- implementation and defaults of views shipped block
- usability of having 2 implementations of "recent comments block"
Comment #34
andypost