Fix UI on the install new stuff pages [#614288]

Comment	File	Size	Author
#8	614288-8.install-new-stuff-ui.patch	2.55 KB	dww

#8	614288-8.install-new-stuff-ui.png	51.1 KB	dww
#7	614288-install-new-stuff-ui-7.patch	2.34 KB	ksenzee

#5	screenshot_042.png	33.03 KB	ksenzee
#5	614288-install-new-stuff-ui.patch	2.34 KB	ksenzee

#1	614288-1.install_page_d_o_links.png	52.7 KB	dww

Comment #1

we/he/they

CreditAttribution: dww commented 28 October 2009 at 11:25

Assigned:	Unassigned	» dww
Status:	Active	» Needs review

File	Size
614288-1.install_page_d_o_links.png	52.7 KB

Uhh, the page already has those links. ;)

I guess I just missed them. :( UI review on this page?

Log in or register to post comments

Comment #2

yoroy CreditAttribution: yoroy commented 28 October 2009 at 12:58

Issue tags:

+ui-text

- The title 'Available updates' seems off, as the page is about installing new things. Only new things or does that include updates to already used stuff as well?

- 'URL' is quite sparse a label. 'Install from this URL'?
- 'Paste' is then quite specific :-) No need to make explicit that it needs filling out. Suggestion " The URL to a module or theme archive to install, for example: http://etc…" (e.g. is a rather abstract abbreviation, probably well known but 'for example' is simpler and clearer).
- Don't use the word 'Drupal', the Drupal context is a given and it complicates forks/profiles (see http://drupal.org/node/501452)

- The choice between giving a URL and uploading is not communicated elegantly yet. Can we make a choice on which to show by default and give a link to show/hide the other option? Show the URL field only first, link to show the upload option, hide the URL field?

- Description for the upload button is redundant, remove it and rewrite the label to say "Upload a module or theme archive to install"

Log in or register to post comments

Comment #3

yoroy CreditAttribution: yoroy commented 28 October 2009 at 13:01

Eh, the description for the URL field could just be the example if the label has the basic info already:

Install from this URL
[……………………………]
For example: http://ftp.drupal.org/files/project/projectname.tar.gz

Log in or register to post comments

Comment #4

dww

we/he/they

CreditAttribution: dww commented 28 October 2009 at 13:20

Title:	Link to d.o/project/modules + themes on the Install new stuff pages	» Fix UI on the install new stuff pages
Status:	Needs review	» Needs work

Thanks for the review. This page definitely needs work. ;)

One quick reply:

- The title 'Available updates' seems off, as the page is about installing new things. Only new things or does that include updates to already used stuff as well?

That's an artifact of this page living as an action link off the "Available updates" report. It therefore doesn't get a page title of its own. There's a big debate brewing about this whole thing, which we need to hash out. Basically, Dries committed #602490: Fix help text and action links to find the update manager pages without any review from the UI team (it was just needs review, not RTBC), but that should be reopened and potentially some sweeping changes need to happen there... The action links were originally from #538660-93: Move update manager upgrade process into new authorize.php file (and make it actually work). That was just the best I could come up with on very short time to get *something* in. But, we should really step back and figure out the IA for all these pages and exactly how we expect people to find everything. But, that's for #602490 not here. ;)

Log in or register to post comments

Comment #5

ksenzee

she/her

Seattle area

CreditAttribution: ksenzee commented 13 January 2010 at 23:24

Status:

Needs work

» Needs review

File	Size
614288-install-new-stuff-ui.patch	2.34 KB

screenshot_042.png	33.03 KB

Here's a stab at it. I've highlighted the text I changed in the screenshot.

update manager UI

Log in or register to post comments

Comment #6

dww

we/he/they

CreditAttribution: dww commented 14 January 2010 at 00:02

Assigned:	dww	» Unassigned
Status:	Needs review	» Needs work

Great, thanks! That's better. However, it still references "Drupal" in the description for the "Install from a file". See yoroy in #2:

Don't use the word 'Drupal', the Drupal context is a given and it complicates forks/profiles (see http://drupal.org/node/501452)

Log in or register to post comments

Comment #7

ksenzee

she/her

Seattle area

CreditAttribution: ksenzee commented 14 January 2010 at 00:47

Status:

Needs work

» Needs review

File	Size
614288-install-new-stuff-ui-7.patch	2.34 KB

Happy to oblige.

Log in or register to post comments

Comment #8

dww

we/he/they

CreditAttribution: dww commented 14 January 2010 at 02:48

File	Size
614288-8.install-new-stuff-ui.png	51.1 KB
614288-8.install-new-stuff-ui.patch	2.55 KB

Sorry, #7 is still a bit wonky as per yoroy's feedback from #2 regarding the upload UI. I agree we could make this a lot better if we were more fancy with JS to hide/reveal the two options or something. But, I don't want to get too crazy or we risk not making *any* improvements before alpha1. So, here's a new patch that at least cleans up the labels and descriptions a bit more:

Log in or register to post comments

Comment #9

Bojhan CreditAttribution: Bojhan commented 14 January 2010 at 10:49

The only thing, I would work on is using a normal upload form element so, such as Attach a new file, displayed on each new comment on d.o issues.

Log in or register to post comments

Comment #10

dww

we/he/they

CreditAttribution: dww commented 14 January 2010 at 16:57

Re: #9: It is a normal upload form element. That's just how they look in safari. ;)

  $form['project_upload'] = array(
    '#type' => 'file',
    '#title' => t('Upload a module or theme archive to install'),
    '#description' => t('For example: %filename from your local computer', array('%filename' => 'projectname.tar.gz')),
  );

So, RTBC?

Should the examples include "projectname-version.tar.gz" or something? E.g. an actual URL to use would be:

http://ftp.drupal.org/files/projects/cvs_deploy-7.x-1.x-dev.tar.gz