'Undefined index' on admin/reports/fields and 'change widget' form [#609506]

Comment	File	Size	Author
#2	field_ui_warnings.patch	2.45 KB	yched

Comment #1

johanneshahn CreditAttribution: johanneshahn commented 21 October 2009 at 19:29

hi,
it seems there are some problems with the array structure of field bundles.
take a look at field_ui.admin.inc -> function field_ui_fields_list()

line wich makes trouble:
$rows[$field_name]['data'][2][] = l($bundles[$bundle]['label'], $admin_path . '/fields');

i think thats a temporary bug until they fix the fields structure ;).

Log in or register to post comments

Comment #2

yched CreditAttribution: yched commented 23 October 2009 at 17:26

Status:

Active

» Needs review

File	Size
field_ui_warnings.patch	2.45 KB

Attached patch fixes this and another warning on 'change widget' form. (+ one whitespace fix)
These are remnants from #470242: Namespacing for bundle names.

CNR, but this should be RTBC, really.

Log in or register to post comments

Comment #3

yched CreditAttribution: yched commented 23 October 2009 at 17:29

Title:

Notice: Undefined index: label in field_ui_fields_list() (line 25 of /var/www/www-lan.webthatworks.it/d7/modules/field_ui/field_

» 'Undefined index' on admin/reports/fields and 'change widget' form

Frendlier title

Log in or register to post comments

Comment #4

bjaspan CreditAttribution: bjaspan commented 23 October 2009 at 17:36

Status:

Needs review

» Reviewed & tested by the community

This patch looks fine, but then let's re-open it to make a test to verify the Field List page works at all. Field UI needs more tests.

Log in or register to post comments

Comment #5

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 24 October 2009 at 05:26

Status:

Reviewed & tested by the community

» Fixed

Committed to HEAD. Thanks!

Tests for Field UI are being wrangled at #600544: Tests for Field UI. I'd love to get that to a semi-committable state asap so we can get a baseline in to catch glaring problems like this.