Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If you go to admin/structure/menu/manage/management, for example, and click the save button, you get no feedback that anything happened. A drupal_set_message() should display something generic like "Your configuration has been saved." Check what other places in core are doing for a hint.
Comments
Comment #1
lisarex CreditAttribution: lisarex commentedSee also #620592: Taxonomy admin page ... need feedback when saving. The issues are identical.
Comment #2
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedAttached patch provides appropriate status message when you add or edit a menu or menu item.
Comment #3
Dries CreditAttribution: Dries commentedCan we simplify the message and make it consistent with #620592: Taxonomy admin page ... need feedback when saving?
Comment #4
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedThat sounds good. I had the same thought when i am rolling this patch, but other status messages in the menu module is using something similar to "The new menu %name has been created". Anyways i will roll it again.
Comment #5
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedAttached patch simplifies the status message and makes it consistent with #620592: Taxonomy admin page ... need feedback when saving.
Comment #6
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedComment #8
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedAttached patch should work
Comment #11
baronmunchowsen CreditAttribution: baronmunchowsen commentedI applied the patch in #8 and created a link from admin/structure/menu/manage/management and got a feedback message 'Created new menu link Test Link.', so it seems to work . I have not reviewed the PHP code. I also noticed that in the menu.test file that some of the UI text strings were inconsistent - some with periods ('.'), some without. Not sure if this is a concern or not, or deserving of its own issue.
Comment #12
flickerfly CreditAttribution: flickerfly commentedI applied the patch in #8 and it was grumpy.
Comment #13
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedAttached patch should work.
Comment #14
flickerfly CreditAttribution: flickerfly commented#13 applied properly and provided a message saying that menu items had changed when saved. It checks out nicely for me.
Comment #15
webchickHey, thanks for this. Unfortunately, we're not making any more non-critical changes to the user interface text this release. :( Bumping to Drupal 8.
Comment #16
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedI don't think it is good to leave this bug open for UI text freeze. I agree that #13 makes unwanted checks and UI text changes. Attached patch will fix this bug just by adding three
drupal_set_message(t('Your configuration has been saved.'));
inmenu_foo_bar_submit()
. I am sure its worth adding this now.For Testing
1. Go to List menu links page eg. admin/structure/menu/manage/user-menu
2. Go to menu item edit page eg. admin/structure/menu/item/28/edit
3. Go to menu description edit page eg. admin/structure/menu/manage/user-menu/edit
Submitting menu form in any of the above pages should display
drupal_set_message(t('Your configuration has been saved.'));
message.Comment #17
ghills88 CreditAttribution: ghills88 commentedPatch file from #16 applies cleanly to CVS HEAD for me and has the desired effect. Those different edit pages all show a message when the configuration changes are saved where they did not before.
Comment #18
joachim CreditAttribution: joachim commentedSame here.
RTBC :)
Comment #19
yoroy CreditAttribution: yoroy commentedI did notice this lack of feedback on certain admin pages, too. Definitely worth fixing for D7.
Comment #20
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented@yoroy That's true, One of the admin pages i recently noticed is reported here #787684: Role admin page should say something when you save hope someone here will have time to put some effort.
Comment #21
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.