No friendly URL in link title [#60910]

Comment	File	Size	Author
#3	statistics.module.patch_1.txt	1.82 KB	doq
	statistics.module.patch_0.txt	421 bytes	doq

Comment #1

doq CreditAttribution: doq commented 28 April 2006 at 19:46

Status:

Active

» Needs review

Log in or register to post comments

Comment #2

Dries CreditAttribution: Dries commented 2 May 2006 at 13:33

Version:	4.7.0-rc3	» 4.7.0
Status:	Needs review	» Needs work

Hi doq, thanks for the patch. Looking at the statistics module it seems as if _statistics_column_width() is only used for links. Maybe you could go one step further and move the path lookup to that function? It that is a viable solution, I suggest renaming _statistics_column_width() to _statistics_prune_url() or something equivalent. Care to investigate this a bit more?

Log in or register to post comments

Comment #3

doq CreditAttribution: doq commented 4 May 2006 at 20:52

File	Size
statistics.module.patch_1.txt	1.82 KB

Attaching new patch.

P.S. Have found smth:
function l(...) have a code inside, like check_url(url(...)).
Is that neccesary to check_url, 'cos url has a filter_xss_bad_protocol(...) inside which is the same as check_url(...). You better look in this.