We all know of the Powerd by icon, or perhaps you don't - because we all disable it, for not looking nice with any theme beside Garland that we enable.
As we are looking to provide more of a base to designers, we should also take a look at the ascetics that Drupal provides out of the box. This ascetic, apart from poorly matching any other theme also seems to be somewhat unconnected with everything in its surroundings - it looks like a button, and buttons draw attention. Where I as designer or developer would not want to draw that much attention to it.
So after talking with a few themers and yoroy, we decided to replace the Powerd by Icon with a simple "Powerd by Drupal" text. I think the effects this small change could bring are major. As people will decide to keep the Powerd by block, because aesthetically it looks nice with their theme.
Comment | File | Size | Author |
---|---|---|---|
#35 | powered-by-608478-35.patch | 1.55 KB | David_Rothstein |
#22 | powerdbygone-nobinary-with-tests-span.patch | 4.89 KB | seutje |
#19 | powerdbygone-nobinary-with-tests2_1.patch | 4.88 KB | seutje |
#12 | powerdbygone-nobinary-with-tests2.patch | 4.86 KB | seutje |
#9 | powerdbygone-nobinary-with-tests.patch | 4.79 KB | seutje |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedBefore
After
Comment #2
seutje CreditAttribution: seutje commentedI kinda like this, not only is a lot more clear than just a simple image, but it also adapts to themes a lot easier
+1, but only if u fix the spelling error from "Powerd" to "Powered" :P
and maybe consider running it trough a theme function anyway, just to make it easy to override so this block doesn't remain to be the most unused block that ships with core
Comment #3
Bojhan CreditAttribution: Bojhan commentedSure, sounds good. I just liked the sound "Powerd" more then "Powered" :P
Comment #4
seutje CreditAttribution: seutje commentedHow about this?
this adds an option to the block configuration that's just a checkbox that reads "Use textual link" (this needs some thought though, coz my current implementation sorta sucks and is prolly confusing as hell)
by default it will set this checkbox enabled, thus showing a textual link instead of the badge, but I retained the option to switch to the old badge and have all the options one had before
in addition, the textual version can be overriden by overriding theme_system_powered_by
@TODO: figure out a way to make it clear that when the "use textual link" checkbox is checked, the user understands that the badge won't be used (some book.module style ahah could help us hide that part of the form untill the checkbox is unchecked)
Comment #5
Bojhan CreditAttribution: Bojhan commentedYou are acting on the assumption that there will be a discussion about this, and on forehand choosing a concession to that discussion? I do not think an option is appropriate here, this patch chooses a direction - if you do not agree with that direction, then fine. But we are not putting a "We can't decide" option in on forehand. Text is better, for all the mentioned above reasons - there is no reason to keep an image.
Comment #6
seutje CreditAttribution: seutje commentedpft fine, attached patch gets rid of all the images, all the settings in the block, but retains the theme function for overridability
not sure how these binary changes work, but I seemed to have managed to get it included in the patch
Comment #7
seutje CreditAttribution: seutje commentedversion without binaries (this one won't attempt to delete the PNG files)
Comment #9
seutje CreditAttribution: seutje commentedattached patch also removes the block save handler and changes the tests to reflect the changes
Comment #10
kika CreditAttribution: kika commentedBig +1. Let's remove the visual cruft branding of D5-D6, embrace the minimalistic style and develop proper badges/branding solutions over "Evangelize/Share Drupal" in drupal.org.
Kill all the files and code for images.
Comment #11
Damien Tournoud CreditAttribution: Damien Tournoud commentedMakes sense to me. PHP code is not the place to deal with UI images anyway.
Comment #12
seutje CreditAttribution: seutje commentedthat seemed kinda useless in system_block_view(); now
Comment #13
Bojhan CreditAttribution: Bojhan commentedback to RTBC
Comment #14
q0rban CreditAttribution: q0rban commented+1 for removing the image and replacing with text.
-1 for 'Powerd'.
:)
Comment #15
JohnAlbinYeah, blue icon means it gets disabled if it clashes with the theme you want to use.
Plus “scary white eye balls staring at you through a narrow gap” doesn't really convey user-friendly software; its more of a “I'm stalking you and peeping through your mail slot.” ;-)
RTBC+1
Comment #16
yoroy CreditAttribution: yoroy commentedYes, please remove the graphic version. All those versions are silly (ever saw another one but the default?) and the text version is nicely understated and will look better across themes and more likely to survive.
Comment #17
mortendk CreditAttribution: mortendk commentedwhat johnalbin said ;)
+1 for everytime we remove an image from core and replace it with text :)
Comment #18
q0rban CreditAttribution: q0rban commentedWhoops, Bojhan set me straight, there is no 'Powerd' in the patch.
+1!
Comment #19
seutje CreditAttribution: seutje commentedjust occurred to me I didn't wrap this in proper
<p></p>
leaving it a regular textnodeor does any1 feel this should be a span or something?
Comment #20
q0rban CreditAttribution: q0rban commentedseutje I don't think p is appropriate (semantically). I think it's fine just leaving it an anchor with a class.
Comment #21
q0rban CreditAttribution: q0rban commentedor a span wrapping the whole thing makes sense I guess
Comment #22
seutje CreditAttribution: seutje commentedokay, changed
<p>
into<span>
Comment #23
Dries CreditAttribution: Dries commentedOK, committed to CVS HEAD!
Comment #24
xmacinfoQuotes like this are sad. Our community deserve more than shutting down discussion.
As for myself, I prefered the badged versions than the plaintext version. However, now that this landed, we should also remove the Powered by Drupal block altogether.
It does not make sense to have a text only block in core anymore. Any themer know how to add a few words of text anywhere in their theme. :-)
Comment #25
Bojhan CreditAttribution: Bojhan commented@xmacinfo Sorry, but the community also deserves more then a half-broken UX. Its fine to have discussions, but we are now in a UX polish phase - everything is going to be done on a faster pase. I think it might be nice to trust the UX-Team a bit more on these type of discussions, we know what we are doing - and we are trying to put UX and general design principles over purely opinions.
I see no reason to remove the whole block, its not a technical reason it exists nor a capability one.
Comment #26
seutje CreditAttribution: seutje commentedthe icons are still in the repository btw
Comment #27
David_Rothstein CreditAttribution: David_Rothstein commentedI think the icons should stay in the repository - they were apparently there before the Powered by Drupal block ever existed, and people might find them useful? See #183332: Add an optional 'Powered by Drupal' block for the history...
However, the patch that was committed seems to need work:
1. There is code left behind in system.js related to the image switching - shouldn't that be removed?
2. Aren't we now leaving a couple stale variables (drupal_badge_color and drupal_badge_size) around in the database which should be deleted?
[3, sort of.] From history of the previous issue: The alt-text "Powered by Drupal, an open source content management system" was specifically chosen for SEO-friendliness, and now we are removing any references to "open source CMS".... I could personally care less about SEO, but bringing it up as a possible issue because some people do care :)
While I think there are some good things about this change, I also am not sure it was discussed enough. The comments above seems focused on designers, themers, etc, but that is something only high end Drupal sites can afford to worry about. Perhaps someone could comment on why (or if) this change is good for a small personal site? Having a cute little Drupal icon that they can choose to display and have some control over how it appears - to me that is similar to the Garland color wheel. It is not something a serious themer will really use, but it allows a regular person to start with stock Drupal and customize it a bit. Plenty of Drupal sites display this image now and I wonder if they lose something as a result of this change.
Comment #28
xmacinfo@Bojhan: I respect a lot of the work being done by the UX theme in general. However it does not mean that you know everything.
You are the ones making opinions here. A few themer discussion does not make a fact.
Also I am a UX designer, and I know when some changes are really usability related.
Please refrain saying that you know what you are doing.
Comment #29
q0rban CreditAttribution: q0rban commented@xmacinfo @bojhan, this is not going to be productive, so just stop now. Everyone here is just trying to make Drupal a better product. We may have different opinions about what that actually looks like, and a lot of those opinions are based on years of experience and yet may still be diametrically opposed.
@xmacinfo, Please don't just copy and paste snippets of postings and flame about them. I'm not going to give my opinion on whether its justified or not, because that is not the point. The fact of the matter is that it is just plain unproductive.
If you want to create a new issue to have the block completely removed, please do. You'd probably have my support, but doubtful you'd have support from the people that matter (Dries/webchick/etc). This issue appears to have support, and I think is a much better solution as you can still use CSS to pop your image in there if you want to, but you can't (easily) replace a hard coded image with text. (Come to think of it, we could have the image replacement css in there by default, and then it would be very easy for themes to just override that css).
Thanks! :)
Comment #30
Bojhan CreditAttribution: Bojhan commented@David Nice catches, yes they need to be removed. Regarding discussion, all I can say is 3.5 weeks - and it should probally even be better for personal sites :( . Leaving it in the images map seems fine to me.
@xmacinfo I am not saying just me, I am saying JohnAlbin, Morten, yoroy - if you disagree with 5 persons, fine. But please don't hold us continuing against me.
Comment #31
jbrown CreditAttribution: jbrown commentedSee also: #661806: 'Powered by Drupal' block should link to drupal.com, not drupal.org
Comment #32
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedWould anyone care to make a patch to remove the last stuff mentioned in #27?
Comment #33
Bojhan CreditAttribution: Bojhan commentedComment #34
David_Rothstein CreditAttribution: David_Rothstein commentedComment #35
David_Rothstein CreditAttribution: David_Rothstein commentedThis patch removes the leftover variables and JavaScript code.
Comment #36
xmacinfoLooks great from my point of view.
Comment #37
dawehnerComment #38
Dries CreditAttribution: Dries commentedCommitted to 7.x and 8.x. Thanks David.
Comment #39
bfroehle CreditAttribution: bfroehle commentedUntagging since it's been committed to 7.x