Currently the performance module displays its menu items to anyone with the 'access administration pages' perm. This means that on a big site content creators/editors will likely have access to the module settings. This patch creates a real permission called 'administer performance logging'.

CommentFileSizeAuthor
#4 performance_logging_perm_d7.patch2.47 KBfgm
#2 performance_logging_perm_d7.diff2.28 KBdalin
performance_logging_perms.diff2.59 KBdalin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Status: Needs review » Needs work

I like it. Can you create a patch for D7 as well?

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review
FileSize
performance_logging_perm_d7.diff2.28 KB

Here's a patch for D7. Almost byte-for-byte equivalent to the D6 version.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs review » Needs work

The permissions hook changed in D7:
http://api.drupal.org/api/function/hook_permission/7

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs work » Needs review
FileSize
performance_logging_perm_d7.patch2.47 KB

Rerolled so that it now works.

This being done, I'm not too fond of using the same permission for "configure the module" and "access report". Wouldn't it be better to use the system-wide existing permission to "View site reports" from system.module ?

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Status: Needs review » Fixed

Committed. Thank you both.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.