I didn't want the menu item to show, so added the option of making it a MENU_CALLBACK, so its still usable, but has to be directed to manually.

The other alternative is to make the title friendly, rather than just using the url string, which I've done in this patch as well.

Patch attached.

CommentFileSizeAuthor
pageroute.patch3.43 KBsingularo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sepgil’s picture

sepgil CreditAttribution: sepgil commented

There are some issues in your patch:

  • please use relative path for your patches. I don't have a directory "simon" in my home folder ;-)...
  • I get a lot of warnings:
    # notice: Undefined index: hide_menu in /home/sebastian/work/projects/Pageroute/pageroute.module on line 62.
# notice: Undefined property: stdClass::$menu_title in /home/sebastian/work/projects/Pageroute/pageroute.module on line 74
  • watch out for code style issues
sepgil’s picture

sepgil CreditAttribution: sepgil commented
Status: Needs review » Needs work