Running node revision test on my box I have the following fatal error:
Fatal error: Unsupported operand types in D:\psegno\sviluppo\drupal-7.sviluppo\modules\simpletest\drupal_web_test_case.php on line 734

CommentFileSizeAuthor
#1 node_revision_test-606460-2.patch815 bytespeximo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

peximo’s picture

peximo CreditAttribution: peximo commented
FileSize
node_revision_test-606460-2.patch815 bytes

In NodeRevisionsTestCase:setUp() first is created a node then got the settings from this node and create a new one (revision).
The test fail because in DrupalTestCase:drupalCreateNode() we control if $settings->language is setted but not if is empty.
The patch control if $settings->language is empty and solve this problem.

peximo’s picture

peximo CreditAttribution: peximo commented
Status: Active » Needs review
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

The code in NodeRevisionsTestCase:setUp() doesn't set a language value for the nodes passed into drupalCreateNode() so this should work just fine. Also, we would have seen this failure from the test bot. Double check all your code is the most up-to-date code.

peximo’s picture

peximo CreditAttribution: peximo commented
Status: Fixed » Needs review

I have the latest checkout, it is a fatal error so the test bot migth not report it. Just run the node revision test on your box and you see this.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

I confirmed this behavior on my box, fresh head checkout and fresh install.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Actually the bot should be reporting fatal errors. That's really odd...

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Reviewed & tested by the community

Tested and that's the best fix for this.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Thanks. I asked Dave to file a follow-up issue in the PIFR queue about the fact that it's not catching this.

Committed to HEAD!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

#606522: Testbot is missing fatal errors

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.