Relative Path for background Images in style.css [#599886]

I tried the latest version of this theme - on my drupal installation no images where shown on the page, cause i unpacked the theme to path not corresponding to the /sites/all/themes..

I changed the pathes in the style.css to relative ones and everthing was working fine for me..
Attached to this Posting you'll find a patch for style.css ..

Comment	File	Size	Author
#4	style.patch	11.56 KB	SteffenR
#2	style.patch	12.57 KB	SteffenR
	style.patch	13 KB	SteffenR

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dman CreditAttribution: dman commented 9 October 2009 at 08:25

Good start, but

-  background: url("/sites/all/themes/sports/icon-images/text-html.png") no-repeat right;
+  background: url("/sites/dev.port11.de/themes/sports/icon-images/text-html.png") no-repeat right;
...

o_O ?

You don't really need the ./ either, when just images/... will work.

Comment #2

SteffenR

English

Bremen

CreditAttribution: SteffenR commented 9 October 2009 at 09:11

File	Size
style.patch	12.57 KB

oh - that's right.. i changed it and attached an updated patch file.

Comment #3

dman CreditAttribution: dman commented 9 October 2009 at 09:16

The joys of search & replace :-B

-The HTML markup for this Drupal page is appalling
+The HTML markup for this Drupal page is appdev.port11.deing

... I have nothing to do with the theme, just a free review ;-)

Comment #4

SteffenR

English

Bremen

CreditAttribution: SteffenR commented 9 October 2009 at 11:33

File	Size
style.patch	11.56 KB

You're right search & replace can be really annoying - i just wanted to create a quick patch on the style.css and i hope it'll end up with the last patch file i'm posting here.. I downloaded the original theme again, changed the pathes - now i hope the patch will work as noticed ..

Thanks for your patience - it's the first patch "in my live" - and i'll be more careful next time ;)..

Comment #5

dman CreditAttribution: dman commented 9 October 2009 at 11:53

Status:

Active

» Reviewed & tested by the community

it's the first patch "in my live"

... I could tell ;-)
Just wanted to give you some friendly encouragement, because it's mostly right! And useful.
I'm not actually testing, but thought I'd be able to point out a few 'gotchas'. So now we know...
Looks good about now!