Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.So if a user enables the contact.module, any users that go to /contact get a 404 because it hasn't been configured yet. Why can't we be good and enable a 'Default' contact category with the recipient being the site e-mail address?
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 597540-contact-default-cat-D7.patch | 3.06 KB | Dave Reid |
| #5 | 597540-contact-default-cat-D7.patch | 3.8 KB | Dave Reid |
| #4 | 597540-before-settings.png | 45.53 KB | Dave Reid |
| #4 | 597540-before-form1.png | 53 KB | Dave Reid |
| #4 | 597540-before-form2.png | 68.42 KB | Dave Reid |
Comments
Comment #1
Dave ReidPatch for review.
Comment #2
yoroy CreditAttribution: yoroy commentedYes yes yes. Users are much happier changing a preset than filling in a blank canvas. This is a big little annoyance we can remove here. Will apply the patch and report back. First feedback would be that 'default' may be too generic a label ("Oh dear, that's the default, best not change that"). I find myself typically using the suggested 'website feedback' all the time.
Comment #3
Dave ReidComment #4
Dave ReidBojhan wanted some screenshots:
BEFORE PATCH (current behavior):
If user installs contact.module the site-wide contact form and goes to /contact this is what the admin sees:
http://drupal.org/files/issues/597540-before-form2.png
This is what the non-admin users on the site see at /contact (if the user created a menu link to the contact form but didn't set it up)
http://drupal.org/files/issues/597540-before-form1.png
The admin then usually goes to admin/structure/contact and has to add a default category that usually just goes to the site's e-mail address.
http://drupal.org/files/issues/597540-before-settings.png
AFTER PATCH:
User installs contact.module and it automatically adds the default category and uses the site's e-mail address as the recipient. This would be what the contact settings look like after the module is installed without any kind of intervention or adjusting:
http://drupal.org/files/issues/597540-after-settings.png
After install, if the admin user or any non-admin users go to /contact this is what they would see (a working contact form):
http://drupal.org/files/issues/597540-after-form.png
Comment #5
Dave ReidRe-rolled with yoroy and Bojhan's suggestion to change the new category name from 'Default' to 'Website feedback' which when the admin adds another contact form won't be quite so ambiguous.
Comment #6
Bojhan CreditAttribution: Bojhan commentedI think that this is a good change, as yoroy explained it is important to have good defaults. Since people have a better understanding of what it does, most importantly though when you enable contact module. You can immediately see it working - which avoids a confusion upfront.
This is RTBC
Comment #7
Dries CreditAttribution: Dries commentedI like this patch and I'm more than happy to commit it, but it needs a quick reroll so it actually applies.
Comment #8
Dave ReidRe-rolled for latest commits.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!